New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-links can not register Punycode-ed URL #54

Open

kentoku24 opened this issue Oct 6, 2020 · 1 comment · May be fixed by #55

kentoku24 commented Oct 6, 2020

Legitimate URL such as https://xn--wmq0m700b.jp/h30 is considered to be invaild URL.

This happens because underlying library "validators (0.12.0)" does not recognize the URL above as "correct" URL.

solution:
Use the latest version of library such as validators 0.18.1

itsojon mentioned this issue

False positive on punycode -ed URL #53

Closed

kentoku24 linked a pull request

that will close this issue

updated validators library version to be 0.18.1 #55

Open

Collaborator

itsojon commented Oct 6, 2020

@kentoku24 thank you for submitting this issue and sending a PR! I'll review shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment