Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this abandoned? #10

Open
Chromie192 opened this issue Dec 27, 2021 · 12 comments
Open

Is this abandoned? #10

Chromie192 opened this issue Dec 27, 2021 · 12 comments

Comments

@Chromie192
Copy link

Doesn't work in Foundry 9.0, would love to use it.

@tesolberg
Copy link

2nd that.

@Codex966
Copy link

3rded. This was an excellent tool.

@Codex966
Copy link

Nvm, did it myself.

Added Halfwalk's 8.0+ compatibility for tiles.js, added new theme colors (Red, Green, Purple, White), and changes it all to .webp for file size optimization.

https://github.com/Codex966/fvtt-clocks

@woodinthehood
Copy link

@Codex966 Thanks for the update. FYI, I think with how you've currently configured it, the original blue and yellow themes don't work, since it's trying to pull .webp files when there's only .jpeg's in those folders. Unless I'm missing something, which is very possible lol

@Codex966
Copy link

Codex966 commented Jan 16, 2022

@woodinthehood shoot, you're right, I forgot to push the modified images for those folders. I'll update it asap

@woodinthehood
Copy link

woodinthehood commented Jan 16, 2022

Also, is the Actor functionality working as intended? At least from the little bit I've worked with it, it doesn't seem like you're able to edit the clock Actor while its out on the map. The icons (+/-, palette, etc) that are supposed to appear around it when you right click don't, and you can't edit it from the toolbar either.
Not really my area of expertise, so not sure how to tell what isn't working here unfortunately.

@Chromie192
Copy link
Author

Also, is the Actor functionality working as intended? At least from the little bit I've worked with it, it doesn't seem like you're able to edit the clock Actor while its out on the map. The icons (+/-, palette, etc) that are supposed to appear around it when you right click don't, and you can't edit it from the toolbar either. Not really my area of expertise, so not sure how to tell what isn't working here unfortunately.

I also can't do the same.

And I'm not able to even select the Tile icon for the Clocks.

@WolfDeity
Copy link

Nvm, did it myself.

Added Halfwalk's 8.0+ compatibility for tiles.js, added new theme colors (Red, Green, Purple, White), and changes it all to .webp for file size optimization.

https://github.com/Codex966/fvtt-clocks

All of my attempts to install your version just end up with me downloading this version. even the official install link you posted says the newest supported version is 0.7.9.

@tesolberg
Copy link

The manifest file links to the original repository of troygoode.

@Chromie192
Copy link
Author

Can you post the mainfest link or something?

@kmap01
Copy link

kmap01 commented Apr 2, 2022

@Codex966 Hey, so just wanted to make a note that a token on the map/canvas won't update unless you modify line 114 of modules/sheet.js.

diff --git a/modules/sheet.js b/modules/sheet.js
index dd99cd2..e4658a8 100644
--- a/modules/sheet.js
+++ b/modules/sheet.js
@@ -111,7 +111,7 @@ export class ClockSheet extends ActorSheet {
     // update associated tokens
     const tokens = actor.getActiveTokens();
     for (const t of tokens) {
-      await t.update({
+      await t.document.update({
         name: actor.name,
         img: clock.image.img,
         actorLink: true

@Argonius-Angelus
Copy link

Given this does seem thoroughly abandoned, I'd like to direct peeps to my version of the Clocks module called Lancer Clocks (name is just because it was designed to better conform to what Lancer wanted from clocks, and also it uses Lancer's clock styles). It's got a number of newer features and for the most part works with versions 0.7.9 and above. The ad-hoc Tiles are disabled as I have yet to figure out how to fix them for 0.8 and above (it's a lot more than just changing a couple of lines around).

https://github.com/Argonius-Angelus/lancer-clocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants