【腾讯犀牛鸟开源课题实战】对接mysql sdk #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weimch
reviewed
Nov 19, 2024
.bazelrc
Outdated
| @@ -0,0 +1,5 @@ | |||
| build --cxxopt="--std=c++17" | |||
| # build --copt=-O2 | |||
There was a problem hiding this comment.
.bazelrc里，只需要留下面的选项就好
build --cxxopt="--std=c++17"
build --copt=-O2
weimch
reviewed
Nov 19, 2024
weimch
reviewed
Nov 19, 2024
weimch
reviewed
Nov 19, 2024
weimch
reviewed
Nov 20, 2024
weimch
reviewed
Nov 20, 2024
weimch
reviewed
Nov 25, 2024
weimch
reviewed
Nov 25, 2024
| #include <iostream> | ||
| #include <memory> | ||
| #include <string> | ||
| #include "trpc/util/string_util.h" |
There was a problem hiding this comment.
不同头文件区块间应该加空格，头文件之间的排布应该是类似这样的，下面以dir2/foo2.cc的头文件引入为例子。
dir2/foo2.h（强关联的头文件，一般.cc文件里写对应.h文件，.h文件里写继承的父类等）
空行
C 系统头文件
空行
C++ 标准库头文件
空行
其他库的 .h文件
（可选）空行
本项目内 .h文件
weimch
reviewed
Nov 25, 2024
weimch
reviewed
Nov 26, 2024
weimch
reviewed
Nov 26, 2024
weimch
reviewed
Nov 26, 2024
weimch
reviewed
Nov 26, 2024
weimch
reviewed
Nov 26, 2024
weimch
reviewed
Nov 26, 2024
weimch
reviewed
Nov 27, 2024
weimch
reviewed
Dec 4, 2024
WORKSPACE
Outdated
| trpc_workspace() | ||
|
|
||
| load("//trpc:workspace.bzl", "database_mysql_workspace") | ||
| database_mysql_workspace() |
# Conflicts: # LICENSE
# Conflicts: # WORKSPACE # cmake/com_github_trpc_cpp.cmake
weimch
reviewed
Dec 9, 2024
README.md
Outdated
| mysql_conf.password = "abc123"; | ||
| mysql_conf.user_name = "root"; | ||
| mysql_conf.thread_num = 8; | ||
| mysql_conf.thread_bind_core = "1, 2-4"; |
There was a problem hiding this comment.
这个改一下，不加空格能解析，但加空格反而不太确定行不行，加空格虽然bindcore返回值是正确的，但Split后会有个TryParse(" 2")，不太确定对不对。那这里不允许加空格吧。
helloopenworld
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue
mysql service相关主体部分