【腾讯犀牛鸟开源课题实战】对接mysql sdk #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weimch
reviewed
Nov 19, 2024
| @@ -0,0 +1,5 @@ | |||
| build --cxxopt="--std=c++17" | |||
| # build --copt=-O2 | |||
There was a problem hiding this comment.
.bazelrc里，只需要留下面的选项就好
build --cxxopt="--std=c++17"
build --copt=-O2
weimch
reviewed
Nov 19, 2024
BUILD
Outdated
weimch
reviewed
Nov 19, 2024
| # | ||
| # Tencent is pleased to support the open source community by making tRPC available. | ||
| # | ||
| # Copyright (C) 2023 THL A29 Limited, a Tencent company. |
weimch
reviewed
Nov 19, 2024
| char_set: "utf8mb4" | ||
| num_shard_group: 4 | ||
| thread_num: 4 | ||
| thread_bind_core: false |
weimch
reviewed
Nov 20, 2024
| endif() | ||
|
|
||
| string(REGEX REPLACE "^([0-9]+\\.[0-9]+)\\..*" "\\1" MYSQLCLIENT_MAJOR_VER "${MYSQLCLIENT_VERSION_TAG}") | ||
| set(MYSQLCLIENT_URL "https://dev.mysql.com/get/Downloads/MySQL-${MYSQLCLIENT_MAJOR_VER}/mysql-${MYSQLCLIENT_VERSION_TAG}-linux-glibc2.17-x86_64-minimal.tar.xz") |
There was a problem hiding this comment.
这个不包含源码，是编译好的版本，因为源码那个仓库太大了，所有在官网找了这个minimal的发布的版本。只是链接的话gcc11是没问题的
weimch
reviewed
Nov 20, 2024
| ) | ||
|
|
||
| target_link_libraries(mysqlclient INTERFACE | ||
| "${MYSQLCLIENT_LIB_DIR}/private/libcrypto.so" |
There was a problem hiding this comment.
ldd命令看下最后构建出二进制程序的so库路径，感觉这两so库得随着二进制发布而发布，程序分发到容器比较麻烦，能不能直接用系统的ssl库？
There was a problem hiding this comment.
这个如果找不到这个特定路径里的so会自动去找系统目录里的，应该没问题
weimch
reviewed
Nov 25, 2024
|
|
||
| int main(int argc, char* argv[]) { | ||
| ParseClientConfig(argc, argv); | ||
| std::cout << "************************************\n" |
weimch
reviewed
Nov 25, 2024
| #include <iostream> | ||
| #include <memory> | ||
| #include <string> | ||
| #include "trpc/util/string_util.h" |
There was a problem hiding this comment.
不同头文件区块间应该加空格，头文件之间的排布应该是类似这样的，下面以dir2/foo2.cc的头文件引入为例子。
dir2/foo2.h（强关联的头文件，一般.cc文件里写对应.h文件，.h文件里写继承的父类等）
空行
C 系统头文件
空行
C++ 标准库头文件
空行
其他库的 .h文件
（可选）空行
本项目内 .h文件
weimch
reviewed
Nov 25, 2024
| trpc::Status s = proxy->Query(ctx, res, "select id, username from users where id = ? and username = ?", 3, "carol"); | ||
|
|
||
| MYSQL_ERROR_CHECK(s, res); | ||
| // const std::vector<std::tuple<int, std::string>>& res_set |
There was a problem hiding this comment.
如果无法从上下推断出res_set的类型，则不应该使用auto，应该使用类型名，此处直接使用类型名就好了，无需增加注释，代码应该有自解释性
weimch
reviewed
Nov 26, 2024
| std::cout << "do something\n"; | ||
| trpc::future::BlockingGet(std::move(future)); | ||
|
|
||
| if(future.IsFailed()) { |
There was a problem hiding this comment.
future在106行被move了，这里用future对象会出现未定义行为，可以在第98行，判断future不为ready打印出错误的信息
weimch
reviewed
Nov 26, 2024
|
|
||
| DEFINE_string(client_config, "fiber_client_client_config.yaml", "trpc cpp framework client_config file"); | ||
|
|
||
| void printResult(const std::vector<std::tuple<int, std::string>>& res_data) { |
weimch
reviewed
Nov 26, 2024
|
|
||
|
|
||
| void TestAsyncTx(std::shared_ptr<trpc::mysql::MysqlServiceProxy>& proxy) { | ||
| MysqlResults<OnlyExec> exec_res; |
weimch
reviewed
Nov 26, 2024
| proxy->Query(ctx, query_res, "select * from users"); | ||
|
|
||
| // Do two query separately in the same one transaction and the handle will be moved to handle2 | ||
| auto fu = proxy->AsyncBegin(ctx) |
weimch
reviewed
Nov 26, 2024
| PrintResultTable(res); | ||
| std::cout << "\n\n"; | ||
|
|
||
| return proxy |
weimch
reviewed
Nov 26, 2024
| } | ||
|
|
||
| std::cout << "\n\n\n"; | ||
| PrintResultTable(res2); |
weimch
reviewed
Nov 26, 2024
| ctx = trpc::MakeClientContext(proxy); | ||
| s = proxy->Execute(ctx, exec_res, "delete from users where username = \"jack\""); | ||
| MYSQL_ERROR_CHECK(s, exec_res); | ||
| if(1 == exec_res.GetAffectedRowNum()) |
There was a problem hiding this comment.
可以用 TRPC_ASSERT(exec_res.GetAffectedRowNum() == 1)
weimch
reviewed
Nov 27, 2024
|
|
||
| std::vector<std::vector<uint8_t>> null_flags; | ||
|
|
||
| std::string error_message; |
weimch
reviewed
Nov 27, 2024
| for(i = 1; i < failed_index.size(); i++) | ||
| error.append(", ").append(fields_meta[failed_index[i]].name); | ||
| error.append(")."); | ||
| error_message.append(error); |
weimch
reviewed
Nov 27, 2024
|
|
||
| template <typename... Args> | ||
| void MysqlResults<Args...>::SetRawMysqlRes(MYSQL_RES* res) { | ||
| mysql_res_ = res; |
There was a problem hiding this comment.
如果 mysql_res_ 不为空，是不是还需要释放？如果不需要的话，注释说明下，这个赋值只会发生一次
weimch
reviewed
Nov 27, 2024
|
|
||
| template <typename... Args> | ||
| bool MysqlResults<Args...>::IsValueNull(size_t row_index, size_t col_index) const { | ||
| return null_flags[row_index][col_index]; |
weimch
reviewed
Nov 27, 2024
|
|
||
| template <typename... Args> | ||
| bool MysqlResults<Args...>::OK() const { | ||
| return error_message.empty(); |
weimch
reviewed
Nov 27, 2024
| bool MysqlStatement::Init(const std::string& sql) { | ||
| mysql_stmt_ = mysql_stmt_init(mysql_); | ||
| if (mysql_stmt_ == nullptr) | ||
| return false; |
weimch
reviewed
Nov 27, 2024
|
|
||
| std::string MysqlStatement::GetErrorMessage() { | ||
| if(mysql_stmt_ != nullptr) | ||
| return std::string(mysql_stmt_error(mysql_stmt_)); |
weimch
reviewed
Nov 27, 2024
| } | ||
|
|
||
| bool MysqlStatement::BindParam(std::vector<MYSQL_BIND> &bind_list) { | ||
|
|
weimch
reviewed
Nov 27, 2024
| class MysqlStatement { | ||
| public: | ||
| MysqlStatement(MYSQL* conn); | ||
| ~MysqlStatement() { assert(mysql_stmt_ == nullptr); } |
weimch
reviewed
Nov 27, 2024
|
|
||
| unsigned long GetParamsCount() { return params_count_; } | ||
|
|
||
| MYSQL_RES* GetResultsMeta(); |
weimch
reviewed
Nov 27, 2024
| }; | ||
|
|
||
|
|
||
| class ExecuteStatus { |
weimch
reviewed
Nov 27, 2024
|
|
||
| MysqlTime &MysqlTime::SetMonth(unsigned int month) { | ||
| if(month > 0 && month <= 12) | ||
| mt.month = month; |
weimch
reviewed
Nov 27, 2024
|
|
||
| enum_mysql_timestamp_type MysqlTime::GetTimeType() const { return mt.time_type; } | ||
|
|
||
| //std::string MysqlTime::ToString() const { |
weimch
reviewed
Nov 27, 2024
| mt.day, mt.hour, mt.minute, mt.second); | ||
| } | ||
|
|
||
| void MysqlTime::FromString(const std::string &timeStr) { |
weimch
reviewed
Nov 27, 2024
| const char *MysqlTime::DataConstPtr() const { | ||
| return reinterpret_cast<const char *>(&mt); | ||
| } | ||
|
|
weimch
reviewed
Nov 27, 2024
| return data_ == other.data_; | ||
| } | ||
|
|
||
| const char *MysqlBlob::data_ptr() const { |
There was a problem hiding this comment.
接口定义保持统一，可以用DataConstPtr，和MysqlTime风格保持统一
weimch
reviewed
Nov 27, 2024
| return data_.data(); | ||
| } | ||
|
|
||
| size_t MysqlBlob::size() const { |
weimch
reviewed
Nov 27, 2024
| const char* DataConstPtr() const; | ||
|
|
||
| private: | ||
| MYSQL_TIME mt{}; |
weimch
reviewed
Nov 27, 2024
|
|
||
|
|
||
|
|
||
| class MysqlExecutorPoolImpl : public MysqlExecutorPool { |
There was a problem hiding this comment.
看上去只有一种 MysqlExecutorPool的实现，不用搞继承，除非有多种MysqlExectuorPool模式实现，需要通过多态来针对不同配置/场景、切换不同的实现模块
weimch
reviewed
Nov 27, 2024
| bool IsIdleTimeout(RefPtr<MysqlExecutor> executor); | ||
|
|
||
| private: | ||
| std::string m_ip_; |
weimch
reviewed
Nov 27, 2024
| std::atomic<uint32_t> executor_num_{0}; | ||
|
|
||
| // The maximum number of connections that can be stored per `Shard` in `conn_shards_` | ||
| uint32_t max_num_per_shard_{0}; |
weimch
reviewed
Nov 27, 2024
|
|
||
| MysqlExecutorPool* MysqlExecutorPoolManager::CreateExecutorPool(const NodeAddr& node_addr) { | ||
| MysqlExecutorPool* new_pool{nullptr}; | ||
| new_pool = new MysqlExecutorPoolImpl(option_, node_addr); |
weimch
reviewed
Nov 27, 2024
| RefPtr<MysqlExecutor> idle_executor{nullptr}; | ||
|
|
||
| uint32_t shard_id = shard_id_gen_.fetch_add(1); | ||
| int retry_num = 3; |
weimch
reviewed
Nov 27, 2024
|
|
||
| namespace trpc::mysql { | ||
|
|
||
| bool InitPlugin() { |
weimch
reviewed
Nov 27, 2024
|
|
||
| namespace trpc::mysql { | ||
|
|
||
| MysqlServiceProxy::MysqlServiceProxy() { |
weimch
reviewed
Nov 27, 2024
| public: | ||
| explicit MysqlExecutorPoolManager(MysqlExecutorPoolOption&& option); | ||
|
|
||
| // MysqlExecutorPtr GetExecutor(const std::string& ip_port); |
weimch
reviewed
Nov 27, 2024
| pool_option.max_idle_time = option->idle_time; | ||
| pool_option.num_shard_group = mysql_conf_.num_shard_group; | ||
| pool_option.char_set = mysql_conf_.char_set; | ||
| pool_manager_ = std::make_unique<MysqlExecutorPoolManager>(std::move(pool_option)); |
There was a problem hiding this comment.
这里类之间关系好像不太对
类关系应该需要符合下面的才对
ExecutorPool(一)<->连接(多)
Manager(一)<->ExecutorPool(多)
ServiecProxy(一)<->ExectuorPool(一)
这样的话，Manager可以声明设计成单例模式，如果程序涉及Manager的Init和Destroy，可以单独提供两个接口，让用户在程序启动时初始化环境、在程序退出时销毁环境。
There was a problem hiding this comment.
哦，看错了，这里没问题，可以注释说下，pool_manager_是应对路由插件返回多个mysqlserver Ip的场景
weimch
reviewed
Nov 27, 2024
|
|
||
| if(!res.OK()) { | ||
| Status status = kUnknownErrorStatus; | ||
| status.SetErrorMessage(res.GetErrorMessage()); |
weimch
reviewed
Nov 27, 2024
|
|
||
| private: | ||
| std::unique_ptr<ThreadPool> thread_pool_{nullptr}; | ||
| std::unique_ptr<MysqlExecutorPoolManager> pool_manager_; |
weimch
reviewed
Nov 27, 2024
|
|
||
| int filter_ret = RunFilters(FilterPoint::CLIENT_PRE_SEND_MSG, context); | ||
|
|
||
| if(filter_ret == 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue
mysql service相关主体部分