diff --git a/README.md b/README.md index e077e67..a019dc1 100644 --- a/README.md +++ b/README.md @@ -39,20 +39,20 @@ Truefoundry Google Cloud platform features module ## Inputs -| Name | Description | Type | Default | Required | -|------|-------------|------|---------|:--------:| -| [blob\_storage\_cors\_origins](#input\_blob\_storage\_cors\_origins) | List of CORS origins for Mlfoundry bucket | `list(string)` |
[| no | -| [blob\_storage\_enable\_override](#input\_blob\_storage\_enable\_override) | Enable overriding name of s3 bucket. This will only be used if feature\_blob\_storage\_enabled is enabled. You need to pass s3\_override\_name to pass the bucket name | `bool` | `false` | no | -| [blob\_storage\_force\_destroy](#input\_blob\_storage\_force\_destroy) | Force destroy for mlfoundry s3 bucket | `bool` | `true` | no | -| [blob\_storage\_override\_name](#input\_blob\_storage\_override\_name) | S3 bucket name. Only used if s3\_enable\_override is enabled | `string` | `""` | no | -| [cluster\_name](#input\_cluster\_name) | Name of the cluster | `string` | n/a | yes | -| [feature\_blob\_storage\_enabled](#input\_feature\_blob\_storage\_enabled) | Enable blob storage feature in the platform | `bool` | `true` | no | -| [feature\_cloud\_integration\_enabled](#input\_feature\_cloud\_integration\_enabled) | Enable cloud integration feature in the platform | `bool` | `true` | no | -| [feature\_docker\_registry\_enabled](#input\_feature\_docker\_registry\_enabled) | Enable docker registry feature in the platform | `bool` | `true` | no | -| [feature\_secrets\_enabled](#input\_feature\_secrets\_enabled) | Enable secrets manager feature in the platform | `bool` | `true` | no | -| [project](#input\_project) | GCP Project | `string` | n/a | yes | -| [region](#input\_region) | region | `string` | n/a | yes | -| [tags](#input\_tags) | A map of tags to add to all resources | `map(string)` | `{}` | no | +| Name | Description | Type | Default | Required | +|---------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------|---------|:--------:| +| [blob\_storage\_cors\_origins](#input\_blob\_storage\_cors\_origins) | List of CORS origins for Mlfoundry bucket | `list(string)` |
"*"
]
[| no | +| [blob\_storage\_enable\_override](#input\_blob\_storage\_enable\_override) | Enable overriding name of s3 bucket. This will only be used if feature\_blob\_storage\_enabled is enabled. You need to pass s3\_override\_name to pass the bucket name | `bool` | `false` | no | +| [blob\_storage\_force\_destroy](#input\_blob\_storage\_force\_destroy) | Force destroy for mlfoundry s3 bucket | `bool` | `true` | no | +| [blob\_storage\_override\_name](#input\_blob\_storage\_override\_name) | S3 bucket name. Only used if s3\_enable\_override is enabled | `string` | `""` | no | +| [cluster\_name](#input\_cluster\_name) | Name of the cluster | `string` | n/a | yes | +| [feature\_blob\_storage\_enabled](#input\_feature\_blob\_storage\_enabled) | Enable blob storage feature in the platform | `bool` | `true` | no | +| [feature\_cluster\_integration\_enabled](#input\_feature\_cluster\_integration\_enabled) | Enable cluster integration feature in the platform | `bool` | `true` | no | +| [feature\_docker\_registry\_enabled](#input\_feature\_docker\_registry\_enabled) | Enable docker registry feature in the platform | `bool` | `true` | no | +| [feature\_secrets\_enabled](#input\_feature\_secrets\_enabled) | Enable secrets manager feature in the platform | `bool` | `true` | no | +| [project](#input\_project) | GCP Project | `string` | n/a | yes | +| [region](#input\_region) | region | `string` | n/a | yes | +| [tags](#input\_tags) | A map of tags to add to all resources | `map(string)` | `{}` | no | ## Outputs @@ -63,4 +63,4 @@ Truefoundry Google Cloud platform features module | [bucket\_url](#output\_bucket\_url) | URL of the bucket | | [serviceaccount\_key](#output\_serviceaccount\_key) | Service account keys | | [serviceaccount\_name](#output\_serviceaccount\_name) | Name of the service account | - \ No newline at end of file + diff --git a/iam.tf b/iam.tf index 4a21816..4810e46 100644 --- a/iam.tf +++ b/iam.tf @@ -100,7 +100,7 @@ resource "google_project_iam_member" "truefoundry_platform_feature_artifact_regi // role binding container cluster viewer role to service account resource "google_project_iam_member" "truefoundry_platform_feature_container_cluster_viewer_role_binding" { - count = var.feature_cloud_integration_enabled ? 1 : 0 + count = var.feature_cluster_integration_enabled ? 1 : 0 project = var.project role = "roles/container.clusterViewer" @@ -109,7 +109,7 @@ resource "google_project_iam_member" "truefoundry_platform_feature_container_clu // role binding container viewer role to service account resource "google_project_iam_member" "truefoundry_platform_feature_container_viewer_role_binding" { - count = var.feature_cloud_integration_enabled ? 1 : 0 + count = var.feature_cluster_integration_enabled ? 1 : 0 project = var.project role = "roles/container.viewer" diff --git a/variables.tf b/variables.tf index a84b7e5..21f8b74 100644 --- a/variables.tf +++ b/variables.tf @@ -82,10 +82,10 @@ variable "feature_docker_registry_enabled" { } ################################################################################ -# Cloud integration +# Cluster integration ################################################################################ -variable "feature_cloud_integration_enabled" { - description = "Enable cloud integration feature in the platform" +variable "feature_cluster_integration_enabled" { + description = "Enable cluster integration feature in the platform" type = bool default = true -} \ No newline at end of file +}
"*"
]