Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

#1239 - Clone workspace #1425

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

TripleSpeeder
Copy link

##Add workspace clone functionality

This should fix https://github.com/trufflesuite/ganache/issues/1239. The new icon "clone-regular.svg" is from FontAwesome project, so no licensing issues expected ;)

PR includes 2 commits - First one adds "clone" method to workspace and according unit tests. Second commit includes actual UI changes.

@TripleSpeeder
Copy link
Author

That's my first PR for Ganache, so feel free to let me know anything that should be changed :)

@davidmurdoch davidmurdoch force-pushed the develop branch 2 times, most recently from e2089a6 to d685a7b Compare September 26, 2019 19:38
@TripleSpeeder
Copy link
Author

PR is now rebased. I realized there was initially a change included on the snapshot.svg icon (removal of incorrect attribute data-stroke="none") which is not related to the cloning feature. I reverted that change with commit 14a6ec5 , but it looks like Travis is now choking on that commit, although from the error the build just seemed to time out? Travis log says

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@TripleSpeeder
Copy link
Author

Rebased again and cleaned up the commits a bit. Also MacOS build was successfull now, but I don't think this is related to my changes - must be some other change on develop branch that fixed it.

Copy link

@RonSherfey RonSherfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in ability to clone workspaces.
2 participants