-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goal: Nuon v2 Price Feed #699
Comments
Hey @georgeciubotaru @markholdex this issue is a request from Nuon a customer of the TSN we need to use Truflations inflation data to create a create a peg price for Nuon please let me know if this issue makes sense and if you have any questions I'd like to get feedback on this as soon as we can. Thanks! CC: @itscameronlee |
I just realized that I didn't include where the data is to be output. The Nuon protocol expects to be able to pull this data from a standard Chainlink oracle. |
@Jarryd-pretorius do you mind putting the description in a Google doc (with comment permission) so we can ask questions over specific elements? |
Done @markholdex |
Hey @markholdex did you have any comments regarding this issue?. Would it be good to get the TSN guys to have a read @outerlook @MicBun |
@zolotokrylin - What's your take on this? Shall we take this task on? |
@rsoury, let's spec it to the extent that no one has questions or concerns. Then we "price" is (XS, S, M, L, XL, XXL) and take it from there in comparison with other issues. I will introduce new labels to mark the size of the EPIC (Goal). |
@zolotokrylin I have left my comments in the doc I think this is something pretty important for Nuon so if @rsoury has capacity to help out on this one from the data provider side that would be great |
Hey @outerlook @MicBun let me know if there are anymore outstanding questions on this issue would like to get it moving thanks! |
Hi @Jarryd-pretorius, @outerlook and I have made some comments on the Spec document. |
Thanks @MicBun I have DM'd @itscameronlee to answer the last outstanding comments, thanks! |
@Jarryd-pretorius I left a set of questions at the bottom of the doc as suggestions. Can you please apply them? And let's comment on individual questions to resolve them and write the answers. There are many unknowns at this stage. |
I appreciate @markholdex's list at the end. I added my concern about mutability |
Awesome thanks @markholdex @outerlook for your questions since this originally was a request from the new Nuon team I have asked Cameron to please comment on your questions so there's no ambiguity 👍 |
Added an implementation suggestion on TSN side for this, based on my current understanding of it, to align expectations. please @MicBun feel free to improve if you notice something on TSN side |
Looks good to me, so basically an entire custom contract for Nuon |
This might be a blocker:
If the inflation index calculations are wrong, the |
@Jarryd-pretorius can you please share edit access with me so I can cleanup the specs? |
Done mate your good to edit now @markholdex |
I highlighted the open questions that need clarification for the coding phase. Almost all seems done. I'm not sure who to tag for these answers (or if I should tag someone) |
@outerlook Best person to tag regarding answers would be @itscameronlee |
@outerlook @itscameronlee is there anything holding this issue back that needs to be resolved? |
Hi @Jarryd-pretorius, only one clarification is pending. I now tagged @itscameronlee on the specs. Thank you |
@outerlook, this Goal is blocked by: |
@zolotokrylin @markholdex - Appreciate the patience on this. I've added my own comments and suggestions. Is there a team responsible for the Nuon EVM Contracts? It may be more relevant for them to revise, and formalise the Spec. Then the TSN team can provide the Oracle integration and Chainlink Automation implementation details. |
|
@outerlook @rsoury @MicBun are there any outstanding questions on the doc that need to be addressed before this can get started? |
@Jarryd-pretorius, We can start, but we won't be able to finish with the desired output yet. One of the requirements is the outputted data is being able to be consumed with ChainLink. Unfortunately, I don't think we are able to work on these two in parallel. |
Ok thanks for the updates guys, I think we will need to go through the centralised system to get this price feed then given the required timeline. I have made an issue here for it https://github.com/truflation/truflation-transformers/issues/322 CC: @itscameronlee |
Log: I've broken the Spec requirement into smaller problems, I will start working on what I think is already unblocked. |
log of the call with @itscameronlee:
This goal will be closed once the remaining Problem is solved: |
Since all the problems have been resolved, I will close the goal. |
Specs
Blocked by
Problem:
Truf-data-provider:
SDK-Js:
ChainLink/EVM:
The text was updated successfully, but these errors were encountered: