Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: Nuon v2 Price Feed #699

Closed
11 tasks done
Jarryd-pretorius opened this issue Oct 31, 2024 · 34 comments
Closed
11 tasks done

Goal: Nuon v2 Price Feed #699

Jarryd-pretorius opened this issue Oct 31, 2024 · 34 comments
Assignees

Comments

@Jarryd-pretorius Jarryd-pretorius self-assigned this Oct 31, 2024
@Jarryd-pretorius
Copy link
Author

Hey @georgeciubotaru @markholdex this issue is a request from Nuon a customer of the TSN we need to use Truflations inflation data to create a create a peg price for Nuon please let me know if this issue makes sense and if you have any questions I'd like to get feedback on this as soon as we can. Thanks!

CC: @itscameronlee

@itscameronlee
Copy link

I just realized that I didn't include where the data is to be output. The Nuon protocol expects to be able to pull this data from a standard Chainlink oracle.

@markholdex
Copy link
Collaborator

@Jarryd-pretorius do you mind putting the description in a Google doc (with comment permission) so we can ask questions over specific elements?

@Jarryd-pretorius
Copy link
Author

Done @markholdex

@Jarryd-pretorius
Copy link
Author

Hey @markholdex did you have any comments regarding this issue?. Would it be good to get the TSN guys to have a read @outerlook @MicBun

@rsoury
Copy link

rsoury commented Nov 6, 2024

@zolotokrylin - What's your take on this? Shall we take this task on?
Will await your confirmation.

@zolotokrylin
Copy link
Contributor

@rsoury, let's spec it to the extent that no one has questions or concerns. Then we "price" is (XS, S, M, L, XL, XXL) and take it from there in comparison with other issues. I will introduce new labels to mark the size of the EPIC (Goal).
But nothing stops us from Specing it 🙏

@Jarryd-pretorius
Copy link
Author

@zolotokrylin I have left my comments in the doc I think this is something pretty important for Nuon so if @rsoury has capacity to help out on this one from the data provider side that would be great

@Jarryd-pretorius
Copy link
Author

Hey @outerlook @MicBun let me know if there are anymore outstanding questions on this issue would like to get it moving thanks!

@MicBun
Copy link
Contributor

MicBun commented Nov 8, 2024

Hi @Jarryd-pretorius, @outerlook and I have made some comments on the Spec document.

@Jarryd-pretorius
Copy link
Author

Thanks @MicBun I have DM'd @itscameronlee to answer the last outstanding comments, thanks!

@markholdex
Copy link
Collaborator

@Jarryd-pretorius I left a set of questions at the bottom of the doc as suggestions. Can you please apply them? And let's comment on individual questions to resolve them and write the answers. There are many unknowns at this stage.

@outerlook
Copy link
Contributor

I appreciate @markholdex's list at the end. I added my concern about mutability

@Jarryd-pretorius
Copy link
Author

Awesome thanks @markholdex @outerlook for your questions since this originally was a request from the new Nuon team I have asked Cameron to please comment on your questions so there's no ambiguity 👍

@outerlook
Copy link
Contributor

Added an implementation suggestion on TSN side for this, based on my current understanding of it, to align expectations.

please @MicBun feel free to improve if you notice something on TSN side

@MicBun
Copy link
Contributor

MicBun commented Nov 8, 2024

please @MicBun feel free to improve if you notice something on TSN side

Looks good to me, so basically an entire custom contract for Nuon

@MicBun
Copy link
Contributor

MicBun commented Nov 11, 2024

This might be a blocker:

tfi: The current inflation index fetched from the Truflation API.

If the inflation index calculations are wrong, the tfi will become wrong too.

@markholdex
Copy link
Collaborator

@Jarryd-pretorius can you please share edit access with me so I can cleanup the specs?

@Jarryd-pretorius
Copy link
Author

@Jarryd-pretorius can you please share edit access with me so I can cleanup the specs?

Done mate your good to edit now @markholdex

@outerlook
Copy link
Contributor

I highlighted the open questions that need clarification for the coding phase. Almost all seems done.

I'm not sure who to tag for these answers (or if I should tag someone)

@Jarryd-pretorius
Copy link
Author

@outerlook Best person to tag regarding answers would be @itscameronlee

@Jarryd-pretorius
Copy link
Author

@outerlook @itscameronlee is there anything holding this issue back that needs to be resolved?

@outerlook
Copy link
Contributor

Hi @Jarryd-pretorius, only one clarification is pending. I now tagged @itscameronlee on the specs. Thank you

@zolotokrylin
Copy link
Contributor

zolotokrylin commented Nov 19, 2024

@rsoury
Copy link

rsoury commented Nov 19, 2024

@zolotokrylin @markholdex - Appreciate the patience on this.

I've added my own comments and suggestions.
I assume this is a WIP Spec, until we have the blocking issues, detailed by Vadim, cleared.

Is there a team responsible for the Nuon EVM Contracts? It may be more relevant for them to revise, and formalise the Spec. Then the TSN team can provide the Oracle integration and Chainlink Automation implementation details.

@zolotokrylin
Copy link
Contributor

Is there a team responsible for the Nuon EVM Contracts? It may be more relevant for them to revise, and formalise the Spec.

@itscameronlee :)

@Jarryd-pretorius
Copy link
Author

@outerlook @rsoury @MicBun are there any outstanding questions on the doc that need to be addressed before this can get started?

@MicBun
Copy link
Contributor

MicBun commented Nov 25, 2024

@outerlook @rsoury @MicBun are there any outstanding questions on the doc that need to be addressed before this can get started?

@Jarryd-pretorius, We can start, but we won't be able to finish with the desired output yet. One of the requirements is the outputted data is being able to be consumed with ChainLink. Unfortunately, I don't think we are able to work on these two in parallel.

@zolotokrylin
Copy link
Contributor

@Jarryd-pretorius
Copy link
Author

Jarryd-pretorius commented Nov 26, 2024

Ok thanks for the updates guys, I think we will need to go through the centralised system to get this price feed then given the required timeline. I have made an issue here for it https://github.com/truflation/truflation-transformers/issues/322

CC: @itscameronlee

@MicBun
Copy link
Contributor

MicBun commented Dec 5, 2024

Log: I've broken the Spec requirement into smaller problems, I will start working on what I think is already unblocked.

@MicBun
Copy link
Contributor

MicBun commented Dec 12, 2024

log: the contract part of this Goal is nearly complete and I have deployed it too into TRUF Network
image

price = ( The inflation index / Divisor ) * Base Value
price = ( 152.585527255088229495 / 146.2388272894838 ) * 1
price = 1.043399554572746686

It still needs the ChainLink part of this Goal to complete which is still blocked.

@markholdex
Copy link
Collaborator

log of the call with @itscameronlee:

  • presented the solution we developed
  • agreed that Nuon team will take over and start implementing the EVM contract on their end following the docs: https://github.com/trufnetwork/evm-contracts
  • Cam will pass the docs to Doggo and do an introduction to him
  • If information will be missing or unclear, we will assist

This goal will be closed once the remaining Problem is solved:

@MicBun
Copy link
Contributor

MicBun commented Dec 18, 2024

Since all the problems have been resolved, I will close the goal.

@MicBun MicBun closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants