Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal: TRUF token based TSN billing (staking) #754

Open
georgeciubotaru opened this issue Sep 25, 2024 · 57 comments
Open

Goal: TRUF token based TSN billing (staking) #754

georgeciubotaru opened this issue Sep 25, 2024 · 57 comments

Comments

@georgeciubotaru
Copy link

georgeciubotaru commented Sep 25, 2024

Specs

Blocked by

@Jarryd-pretorius
Copy link

@markholdex @zolotokrylin @georgeciubotaru I have made a roughly spec on what needs to be done for this, Can you guys please give me your thoughts on the outstanding questions that I put in the doc, thanks!

@zolotokrylin
Copy link
Contributor

I have made my iteration over the Spec doc. Please check.

@zolotokrylin zolotokrylin changed the title Goal: Create TRUF contract staking for API access purpose Goal:TRUF token based TSN billing (staking) Oct 2, 2024
@zolotokrylin zolotokrylin changed the title Goal:TRUF token based TSN billing (staking) Goal: TRUF token based TSN billing (staking) Oct 2, 2024
@markholdex
Copy link
Collaborator

Reviewed and also left a couple comments.

@Jarryd-pretorius
Copy link

Log: had a call with @frankparas regarding this and handed it over

@frankparas
Copy link

frankparas commented Oct 9, 2024

Here desigs and user flow. Feel free to launch the prototype, that is also made.

https://www.figma.com/design/tFWGhDG6WZOwGPsyUO9b7g/TRUF-Token-based-TSN-Billing?node-id=2072-32028&t=nuKaOCOj352bND1h-1

Questions I still have:

  • Can a user generate multiple keys? Or is one key per user?
  • I need help with the text, I am simply not good at it. Who can assist here?

Cc @samueldefi @Jarryd-pretorius @markholdex @srust99 @georgeciubotaru

@zolotokrylin
Copy link
Contributor

zolotokrylin commented Oct 9, 2024

@frankparas,

  1. please move your functions related questions to the Spec doc.
  2. I have added your designs to the description.
  3. We will review copy during design review, don't worry.

@zolotokrylin
Copy link
Contributor

@frankparas I moved your question to the spec doc. Please check and reply inside the doc.

@zolotokrylin
Copy link
Contributor

@frankparas I left you comments in Figma.

@Jarryd-pretorius
Copy link

Log: @frankparas Answered your question in the spec doc, please let me know when the design are ready, thanks!

@zolotokrylin
Copy link
Contributor

I have done interaction over the doc. Please iterate over and over until everything is clear. Then we move back into figma.

@Jarryd-pretorius
Copy link

I have done interaction over the doc. Please iterate over and over until everything is clear. Then we move back into figma.

Added small tweaks from my side and added clear requirements for the UI. please review @frankparas

CC: @zolotokrylin

@frankparas
Copy link

@Jarryd-pretorius please see user flow https://www.figma.com/design/tFWGhDG6WZOwGPsyUO9b7g/TRUF-Token-based-TSN-Billing?node-id=2122-52872&t=x1iIW7PR9p4ge9Zj-1

I had to re-do quite much since we support fiat and TRUF. I want to nail the user flow first, then I'll get to the smaller bits.

@Jarryd-pretorius
Copy link

Log: @frankparas @samueldefi I have responded to you questions on the spec

@markholdex
Copy link
Collaborator

log: updated the specs

@Jarryd-pretorius
Copy link

Log: Responded on the spec, @frankparas did you have any questions left here?

@markholdex
Copy link
Collaborator

markholdex commented Oct 11, 2024

@Jarryd-pretorius I added 2 more use-cases in the specs docs in case we might need them. But up to you to decide.

@frankparas
Copy link

Log: Responded on the spec, @frankparas did you have any questions left here?

Not sure yet really. I am re-doing the flow a bit, it's too complex, I am not happy with it. After that I'll check UI and make changes. I'll keep you posted @Jarryd-pretorius thanks for being on top 🔝 🫂

@Jarryd-pretorius Jarryd-pretorius removed their assignment Oct 14, 2024
@zolotokrylin
Copy link
Contributor

@frankparas what's the Desing ETA, please?

@frankparas
Copy link

@frankparas what's the Desing ETA, please?

Wednesday if everything is good. Missing one flow, need some clarifications (in specs doc).

@Jarryd-pretorius
Copy link

Wednesday if everything is good. Missing one flow, need some clarifications (in specs doc).

@frankparas I have replied

@frankparas
Copy link

frankparas commented Oct 15, 2024

Designs and Prototype link in description of this issue.

@Jarryd-pretorius @srust99 @georgeciubotaru @markholdex @zolotokrylin please review

@markholdex
Copy link
Collaborator

@frankparas I left a couple comments but would advise everyone else to also check. I will have an indepth look tomorrow.

cc: @angelicawill @morenonaitana @Jarryd-pretorius

@frankparas
Copy link

@frankparas I left a couple comments but would advise everyone else to also check. I will have an indepth look tomorrow.

cc: @angelicawill @morenonaitana @Jarryd-pretorius

Replied!

Appreciate it 👍

@markholdex
Copy link
Collaborator

@frankparas what is the ETA for resolution of all comments?

@zolotokrylin
Copy link
Contributor

I replied to you in Figma, @frankparas.

@markholdex
Copy link
Collaborator

@frankparas any updates?

@frankparas what is the ETA for resolution of all comments?

@markholdex
Copy link
Collaborator

@Jarryd-pretorius can you please help follow-up?

@Jarryd-pretorius
Copy link

Log: I have message frank directly on TG about this

CC: @markholdex

@zolotokrylin
Copy link
Contributor

@frankparas, what's the blocker?
cc: @Jarryd-pretorius

@Jarryd-pretorius
Copy link

Jarryd-pretorius commented Oct 24, 2024

Checked the calendar and @frankparas is currently on OOO right now and will be back Monday hence the no reply.

CC: @zolotokrylin @markholdex

@Jarryd-pretorius
Copy link

@angelicawill now that the front end for the migration portal is done can you pick this up from the design side so this can be moved forward while frank is OOO, thanks!

@markholdex
Copy link
Collaborator

@Jarryd-pretorius Angelica is already assigned to this bug which I think should be fixed asap.

@Jarryd-pretorius
Copy link

Yeah no worries, spoke to @frankparas last night and he is working on this again

CC: @angelicawill

@Jarryd-pretorius
Copy link

Log: @frankparas I have added some final comments can we please clean up the figma and resolve everything that is needed there. this has been hanging around for a bit and I want to move it forward so if there is anything outstanding please let me know so we can get it resolved, thanks!

CC: @markholdex @zolotokrylin

@zolotokrylin
Copy link
Contributor

@Jarryd-pretorius sounds good. But please let Mark and me review the designs before they are pushed into coding.

@frankparas
Copy link

@Jarryd-pretorius I am back. Took another pass today and it shall be good to go. I've changed some text and some other things, cleaned up the file, made components.

@zolotokrylin @markholdex

@markholdex
Copy link
Collaborator

@Jarryd-pretorius can we organize a call together with @frankparas and discuss/resolve outstanding comments? Please 🙏

@Jarryd-pretorius
Copy link

@markholdex dont know if I will have time this week I think we are on the same page regarding this, can you and @frankparas have a call to go through it or do you need me there?

@Jarryd-pretorius
Copy link

@markholdex @frankparas was there any questions outstanding for this goal that you need answered from me?

@markholdex
Copy link
Collaborator

log: had a call with @frankparas where we resolved the questions. Will be waiting for the final design update. the ETA is today if no major things appear.

@frankparas
Copy link

Log: designs have been adjusted, simplified. Only thing missing is to finish the flows for switching payment methods.

@frankparas
Copy link

@zolotokrylin
Copy link
Contributor

@frankparas I left a comment inside the Figma

@frankparas
Copy link

@zolotokrylin @markholdex @Jarryd-pretorius here you can find the latest changes according to Vadim's suggestion (thanks for that!). I've re-done all the flows to accommodate the new screens. We now have a new tab "Billing".

https://www.figma.com/design/tFWGhDG6WZOwGPsyUO9b7g/TRUF-Token-based-TSN-Billing?node-id=2482-118212&t=jn7a299mnxxk06Vu-1

Take a look. The end of the tunnel is near!

@zolotokrylin
Copy link
Contributor

@frankparas, thanks! Let's leave it here.

We will focus now on:

  • truflation/test#2

Please talk to @Jarryd-pretorius regarding what's next for you.

@Jarryd-pretorius
Copy link

Hey @frankparas the next thing we need to look at please is truflation/website#1067 and the factsheet

@zolotokrylin zolotokrylin transferred this issue from another repository Dec 2, 2024
@markholdex markholdex transferred this issue from another repository Dec 2, 2024
@markholdex markholdex transferred this issue from another repository Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants