From 6f9a55cf6caf92668e2157e70fa19e2b1a5a6661 Mon Sep 17 00:00:00 2001 From: Katherine Chao Date: Tue, 17 Dec 2024 19:11:09 +0000 Subject: [PATCH 1/3] codeowners qa for js --- javascript/CODEOWNERS | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 javascript/CODEOWNERS diff --git a/javascript/CODEOWNERS b/javascript/CODEOWNERS new file mode 100644 index 000000000..4574f93f5 --- /dev/null +++ b/javascript/CODEOWNERS @@ -0,0 +1,15 @@ +# This is a comment. +# Each line is a file pattern followed by one or more owners. + +# These owners will be the default owners for everything in +# the repo. Unless a later match takes precedence, +# @global-owner1 and @global-owner2 will be requested for +# review when someone opens a pull request. + @global-owner1 @katchao + +# Order is important; the last matching pattern takes the most +# precedence. When someone opens a pull request that only +# modifies JS files, only @js-owner and not the global +# owner(s) will be requested for a review. +*.js @katchao12354353453454565555555555555555555555555555555555555555555555555 #This is an inline comment. +*.js \ No newline at end of file From 78c808632b7e374a404d46ae651b7d2d4cf21996 Mon Sep 17 00:00:00 2001 From: Katherine Chao Date: Tue, 17 Dec 2024 19:14:50 +0000 Subject: [PATCH 2/3] changing a js file --- javascript/src/season.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/javascript/src/season.js b/javascript/src/season.js index 143a345e3..cf369c8dd 100644 --- a/javascript/src/season.js +++ b/javascript/src/season.js @@ -9,4 +9,6 @@ class Season { } } +// changing a js file + export default Season; From f9794117945740b8715072d7dbbea40dc2f58f1e Mon Sep 17 00:00:00 2001 From: Katherine Chao Date: Tue, 17 Dec 2024 21:17:34 +0000 Subject: [PATCH 3/3] add new test --- javascript/tests/jest/__tests__/jest.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/javascript/tests/jest/__tests__/jest.js b/javascript/tests/jest/__tests__/jest.js index 850947d12..5dee1bf2b 100644 --- a/javascript/tests/jest/__tests__/jest.js +++ b/javascript/tests/jest/__tests__/jest.js @@ -15,4 +15,8 @@ describe("Jest - Day of the Week Tests", () => { const today = moment().format("dddd"); expect(["Saturday", "Sunday"]).toContain(today); }); + test("today is Saturday", () => { + const today = moment().format("dddd"); + expect(["Saturday"]).toContain(today); + }); });