Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen-v2] Quality of Life changes for Swift binding generation #3159

Open
5 tasks
lamafab opened this issue May 10, 2023 · 0 comments
Open
5 tasks

[Codegen-v2] Quality of Life changes for Swift binding generation #3159

lamafab opened this issue May 10, 2023 · 0 comments
Assignees
@lamafab
Labels
codegen enhancement New feature or request priority:low

Comments

@lamafab
Copy link
Contributor

lamafab commented May 10, 2023

This is regarding PR #3122. We want to merge it ASAP, but there some low-priority improvements we can do in terms of polishing and UX. Introducing those changes in a separate PR with fewer line changes helps too.

Todo:

  • Replicate codgen v1 naming convention mechanism for Swift naming, assuming it's worth it. Right now we have some custom handlers for certain modules.
  • Generate the WalletCore.h file that currently gets copied directly to swift/Sources/Generated/ with the templating engine.
  • Add proper CLI interface with configuration options (or config file).

Open questions

  • Shorten process_methods and process_properties functions?
  • Use chrono for year calculation (probably overkill)?
@lamafab lamafab self-assigned this May 10, 2023
@lamafab lamafab mentioned this issue May 10, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lamafab lamafab

Labels
codegen enhancement New feature or request priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lamafab and others