We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noexcept
Describe the bug WC makes the end-user app crashing because of the incorrect use of C++ noexcept specifier which ignores throw exceptions.
To Reproduce For example, pass an incorrect EOS signature:
wallet-core/src/EOS/Signer.cpp
Line 149 in b2749b2
Expected behavior WC should either throw an exception or return an error in SigningOutput { error, error_message } Protobuf message.
SigningOutput { error, error_message }
The text was updated successfully, but these errors were encountered:
can I try this? is this issue specifically targeting EOS?
Sorry, something went wrong.
Will this affect any core
No branches or pull requests
Describe the bug
WC makes the end-user app crashing because of the incorrect use of C++
noexcept
specifier which ignores throw exceptions.To Reproduce
For example, pass an incorrect EOS signature:
wallet-core/src/EOS/Signer.cpp
Line 149 in b2749b2
Expected behavior
WC should either throw an exception or return an error in
SigningOutput { error, error_message }
Protobuf message.The text was updated successfully, but these errors were encountered: