Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AbortController/AbortSignal pattern #253

Open
xivk opened this issue Jan 31, 2024 · 1 comment
Open

Implement AbortController/AbortSignal pattern #253

xivk opened this issue Jan 31, 2024 · 1 comment
Milestone

Comments

@xivk
Copy link

xivk commented Jan 31, 2024

I was wondering if it would be useful to do a pull request implementing a version of the geocode call accepting an AbortSignal?

We use it to cancel requests that have not completed yet, for example when the user does a new search before the previous result is available. This improves performance and stops useless requests from being sent and then ignored.

@tsamaya
Copy link
Owner

tsamaya commented Jan 31, 2024

I think that would be great.
Did you see: I was also considering removing the cross-fetch dependency in version 2 of lib #222.

@tsamaya tsamaya added this to the v2 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants