Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence for collections #42

Closed
morlay opened this issue Jan 7, 2016 · 3 comments
Closed

Remove dependence for collections #42

morlay opened this issue Jan 7, 2016 · 3 comments

Comments

@morlay
Copy link

morlay commented Jan 7, 2016

This one will broken other libs
because of montagejs/collections#139

+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| `-- [email protected]

btw, global shim is dangerous
@markdalgleish
Copy link
Collaborator

Would you mind issuing a PR for this?

@morlay
Copy link
Author

morlay commented Jan 8, 2016

sure, i will try fix it this weekend.

seems q-io only in https://github.com/tschaub/gh-pages/blob/master/lib/git.js

@addaleax addaleax mentioned this issue Dec 1, 2016
Closed
@sid-maddy sid-maddy mentioned this issue Dec 16, 2016
Closed
digitil pushed a commit to buildium/gh-pages that referenced this issue Apr 6, 2017
Update q-io dependency
6041160 
q-io depends on `collections`

as mentioned in issue tschaub#42, collections breaks some other libraries
because it modifies Array.prototype

this was corrected in 2.0.1 of collections and the dependency
is updated in v2 of q-io
@theetrain theetrain mentioned this issue Apr 25, 2017
Closed
@tschaub
Copy link
Owner

tschaub commented May 8, 2017

Q and q-io are gone with #166.

@tschaub tschaub closed this as completed May 8, 2017
@qgustavor qgustavor mentioned this issue Jul 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tschaub @markdalgleish @morlay