Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish not returning a promise #465

Open
achingbrain opened this issue Feb 20, 2023 · 0 comments
Open

Publish not returning a promise #465

achingbrain opened this issue Feb 20, 2023 · 0 comments

Comments

@achingbrain
Copy link

The commit message for e1374b3 says to always return a promise but I think this block can still cause the publish method to return void and not Promise<void> - it might be simpler to use the async keyword on the function?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achingbrain