Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic symbols are flipped vertically when no rotation is there #125

Open
imrishabh18 opened this issue Nov 14, 2024 · 4 comments
Open

Comments

@imrishabh18
Copy link
Member

Test file - https://github.com/tscircuit/core/blob/main/tests/components/normal-components/potentiometer.test.tsx
Image

Issues to fix

  • schRotation 180 and 0 are same
  • schematic-symbols and schRotaion 0, if you compare is vertically flipped which should not be the case

Image

@imrishabh18
Copy link
Member Author

/bounty $5

Copy link

algora-pbc bot commented Nov 14, 2024

💎 $5 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #125 with your implementation plan
  2. Submit work: Create a pull request including /claim #125 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/circuit-to-svg!

Add a bountyShare on socials

@anas-sarkez
Copy link
Member

@imrishabh18
I'm already Implemented functions might help you
-flipSymbolOverXAxis
-flipSymbolOverYAxis
in Schematic symbols repo

@imrishabh18
Copy link
Member Author

@anas-sarkez This issue was regarding finding out why the schematic-symbol is flipped over X axis in circuit-to-svg compared to how it's shown in the.

Cause if the user goes to the schematic-symbols directory and see's the symbol, then the schematic view should replicate that on usage. Only when the rotation is added to props, then we can probably use the functions which you have implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants