Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of jscad-fiber is breaking the view in 3d-viewer #92

Open
imrishabh18 opened this issue Nov 16, 2024 · 5 comments
Open

Comments

@imrishabh18
Copy link
Member

imrishabh18 commented Nov 16, 2024

The function createJSCADRenderer is modifying the object structure of jscadPlan. Which in turn is returning undefined type from the jscad-planner https://github.com/tscircuit/jscad-planner/blob/main/lib/execute-jscad-operations.ts. Possible fix should be done in createJSCADRenderer. If not then in jscad-planner

@imrishabh18
Copy link
Member Author

/bounty $10

Copy link

algora-pbc bot commented Nov 16, 2024

💎 $10 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #92 with your implementation plan
  2. Submit work: Create a pull request including /claim #92 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/jscad-fiber!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @Anshgrover23 Nov 16, 2024, 11:54:37 AM #93

@Anshgrover23
Copy link

Anshgrover23 commented Nov 16, 2024

/attempt #92

Algora profile Completed bounties Tech Active attempts Options
@Anshgrover23 2 bounties from 2 projects
JavaScript, Go,
Scala & more
Cancel attempt

@Anshgrover23
Copy link

@imrishabh18 i have made a new PR regarding this.

@Anshgrover23
Copy link

@imrishabh18 sir plss have a look at PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants