Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for 3d viewer error for ux #582

Open
1 task done
ArnavK-09 opened this issue Jan 17, 2025 · 3 comments
Open
1 task done

improve error message for 3d viewer error for ux #582

ArnavK-09 opened this issue Jan 17, 2025 · 3 comments

Comments

@ArnavK-09
Copy link
Contributor

ArnavK-09 commented Jan 17, 2025

cc #562 (comment)

Image

  • willing to submit pr if issue valid
@seveibar
Copy link
Contributor

lol this is actually already the improved version of error message

We are slowly working on generating the 3d models server-side, so maybe we won't even have this error in the future

lmk if you have some ideas here

@ArnavK-09
Copy link
Contributor Author

ArnavK-09 commented Jan 17, 2025

lol this is actually already the improved version of error message

We are slowly working on generating the 3d models server-side, so maybe we won't even have this error in the future

lmk if you have some ideas here

But I think this message should be something like " please switch to 3d view " as this error fixed after switching to 3d view, this can be checked by validating ref as undefined
This error message may make believe user that something internally is wrong and might not switch to 3d view

@seveibar
Copy link
Contributor

i guess i'd accept a PR for it but not compelling enough for a bounty imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants