Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode feature #608

Closed
wants to merge 2 commits into from

Conversation

mdkaifansari04
Copy link

@mdkaifansari04 mdkaifansari04 commented Jan 24, 2025

Added Dark Mode Feature

  • Implemented a dark mode toggle for the website.
  • Ensured consistent styling across all pages in both light and dark modes.
  • Added user preference persistence using [localStorage/sessionStorage].
  • Tested responsiveness and accessibility for the dark mode.

Resolves #602

Screenshots

image
image
image
image
image
image
image
image
image
image

Signed-off-by: Md Kaif Ansari <[email protected]>
Signed-off-by: Md Kaif Ansari <[email protected]>
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why sort all the tailwind class names? The diff isn't readable for changes now

@seveibar
Copy link
Contributor

Try to only change the necessary parts of the code

@seveibar
Copy link
Contributor

I do like the color scheme and button tho, pretty cool

@mdkaifansari04
Copy link
Author

I've formatted the using bun format not sure why the className got sorted

@mdkaifansari04
Copy link
Author

@seveibar can you please check and let me know why the vercel deployment failed, as I cannot access the logs

@seveibar
Copy link
Contributor

took another look at the screenshots, doesn't seem like the code editor is readable 🤔

@mdkaifansari04
Copy link
Author

image

Here is the code editor

@mdkaifansari04
Copy link
Author

do you think the color scheme should be changed

Copy link

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jan 27, 2025
Copy link

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions bot closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Mode
2 participants