Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to make it more amenable to cross compilation #150

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

gbaraldi
Copy link
Contributor

Also cleanup some of it.

This doesn't allow for actual cross-compilation because we need the compilers, and implementing that is basically implementing BinaryBuilder, but maybe we should add an option to pass cc.

@tshort
Copy link
Owner

tshort commented Nov 28, 2023

Plus one from me. Could you add an example in the docs or maybe even a test of a cross compilation? Cross compiling to WebAssembly should work because that's built into the compiler.

Do any of the compilers in Yggdrasil provide cross compilation?

@gbaraldi
Copy link
Contributor Author

Yggy has tons of cross compilers, but they only run in linux.

@brenhinkeller
Copy link
Collaborator

Cool! We should make sure we're being consistent about cflags/c_flags and etc. but otherwise LGTM

Copy link
Collaborator

@MasonProtter MasonProtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would you mind bumping the major version and then I think this is ready to go. Fixes for nightly can be done later once the interfaces and such in nightly stabilize a bit.

@tshort
Copy link
Owner

tshort commented Feb 1, 2024

Sorry. No one pulled the trigger here. Anything else we need to do here?

@brenhinkeller brenhinkeller merged commit 1e6116b into tshort:master Mar 4, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants