Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace calls to tsk_tree_position_t with the internal tree version #2795

Closed
jeromekelleher opened this issue Jul 13, 2023 · 0 comments · Fixed by #2874
Closed

Replace calls to tsk_tree_position_t with the internal tree version #2795

jeromekelleher opened this issue Jul 13, 2023 · 0 comments · Fixed by #2874
Assignees

Comments

@jeromekelleher
Copy link
Member

#2794 outlines the process of using the tks_tree_position_t class to handle the logic of moving between trees. To do this we'll embed a tsk_tree_position_t into the tsk_tree_t struct. A nice consequence of this (I think) is that we'll then have access (withing the library at least) to the edges that were inserted and removed in order to perform the last tree transformation, and this will remove the need to have a separate tree_position_t iterator for the places we're currently using them (since #2786):

  • kc_distance algorithm
  • haplotype matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants