You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
p | p | p |
| | | | | |
a | a | a |
/ \ | / | / |
b c1 | b | b |
| | | | | \ |
c2 | c2 | c2 c3 |
Currently, we can't extend through this: extend_edges will get to here then get stuck:
p | p | p |
| | | | | |
a | a | / |
/ \ | / | / |
/ c1 | / | b |
| | | | | \ |
c2 | c2 | c2 c3 |
... and @nspope has shown that this sort of thing is a fairly common situation in even moderate simulated tree sequences.
Brainstorming with @nspope and @hfr1tz3, we think the principle that can be used here to extend properly is that if there is a chain p -> x -> c somewhere in the tree sequence, then as long as c inherits from p, then x should be intermediate. The argument is that otherwise, c would have had to have inherited two blocks from p along disinct paths, thus requiring an extra (invisible) coalescence somewhere. (Which certainly happens sometimes, but is less parsimonious.)
The next step is to verify how serious this is and assess how hard it is to fix.
The text was updated successfully, but these errors were encountered:
Say we have a true situation like this:
Currently, we can't extend through this:
extend_edges
will get to here then get stuck:... and @nspope has shown that this sort of thing is a fairly common situation in even moderate simulated tree sequences.
Brainstorming with @nspope and @hfr1tz3, we think the principle that can be used here to extend properly is that if there is a chain
p -> x -> c
somewhere in the tree sequence, then as long asc
inherits fromp
, thenx
should be intermediate. The argument is that otherwise,c
would have had to have inherited two blocks fromp
along disinct paths, thus requiring an extra (invisible) coalescence somewhere. (Which certainly happens sometimes, but is less parsimonious.)The next step is to verify how serious this is and assess how hard it is to fix.
The text was updated successfully, but these errors were encountered: