Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C API for numpy 2.0 #2893

Open
jeromekelleher opened this issue Jan 23, 2024 · 4 comments
Open

C API for numpy 2.0 #2893

jeromekelleher opened this issue Jan 23, 2024 · 4 comments
Labels
C API Issue is about the C API Infrastructure and tools Development infrastructure and tools
Milestone
Python 0.6.1

Comments

@jeromekelleher
Copy link
Member

Numpy 2.0 is about to land, and might have some consequences for us at the C level.

Notes on C API changes

More importantly, oldest-supported-numpy is being deprecated, so we may need to change how we're building against numpy and distributing our packages across the tskit projects.
@jeromekelleher jeromekelleher added C API Issue is about the C API Infrastructure and tools Development infrastructure and tools labels Jan 23, 2024
@jeromekelleher jeromekelleher added this to the Python 0.5.7 milestone Jan 23, 2024
@jeromekelleher jeromekelleher mentioned this issue Jan 23, 2024
Closed
@molpopgen
Copy link
Member

More importantly, oldest-supported-numpy is being deprecated, so we may need to change how we're building against numpy and distributing our packages across the tskit projects.

Ooof....

@jeromekelleher
Copy link
Member Author

Ah, comment #2894 (comment) should have been here...

@jeromekelleher
Copy link
Member Author

Looks like the actual code works though, since the conda packages seem to work fine: conda-forge/tskit-feedstock#43

@jeromekelleher
Copy link
Member Author

So, it looks like it's our wheel building infrastructure we need to worry about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C API Issue is about the C API Infrastructure and tools Development infrastructure and tools
Projects
None yet
Milestone
Python 0.6.1
Development

No branches or pull requests
2 participants
@jeromekelleher @molpopgen