diff --git a/.github/CONTRIBUTION_PROCESS.md b/.github/CONTRIBUTION_PROCESS.md index c9e0c3e23f..436fb1ac56 100644 --- a/.github/CONTRIBUTION_PROCESS.md +++ b/.github/CONTRIBUTION_PROCESS.md @@ -2,11 +2,11 @@ This repository contains the developer documentation sources. # Reviewers -On this reposiroty we have primary reviewers and regular reviewers. +In this repository, we have primary and regular reviewers. -Primary reviewers are the people who mostly shape and structure this repository. Although it's not mandatory, it's highly recommended that at least one of them review and approve a Pull Request before he can be merged. +Primary reviewers are the people who mostly shape and structure this repository. Although it's not mandatory, it's highly recommended that at least one of them review and approve a Pull Request before it can be merged. -Primary reviewers are +Primary reviewers are: - @kpodemski - @thomasnares @@ -26,12 +26,12 @@ Pull Requests can be made against different branches. One branch contains the so - branch `1.7.x` contains the sources for PrestaShop 1.7 developer documentation - branch `8.x` contains the sources for PrestaShop 8 developer documentation -Pull Requests only need to be reviewed by reviewers. There is no need to test, unless it introduces a complex change such as a new Hugo markdown. In this situation reviewers should checkout the branch and verify it behaves as expected. +Pull Requests only need to be reviewed. There is no need to test by QA or any other manual tests unless it introduces a complex change, such as a new Hugo markdown. In this situation, reviewers should checkout the branch and verify it behaves as expected. After a Pull Request has been approved it can be merged. ## After the merge -There is no need to milestone merged Pull Requests, however if merger believes the change should be backported on other branches, he can ask kindly the author to do it and add the label 'Needs backport'. +There is no need to milestone merged Pull Requests, however, if the merger believes the change should be backported on other branches, he can kindly ask the author to do it and add the label 'Needs backport'. -When the Pull Request to backport the change to another branch is submitted and merged, the label 'Needs backport' should be replaced by label 'Backported'. \ No newline at end of file +When the Pull Request to backport the change to another branch is submitted and merged, the label 'Needs backport' should be replaced by 'Backported'. \ No newline at end of file