Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\fopSlideRef does not work in footnotes #48

Open
dst97 opened this issue Oct 17, 2022 · 1 comment
Open

\fopSlideRef does not work in footnotes #48

dst97 opened this issue Oct 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dst97
Copy link
Contributor

dst97 commented Oct 17, 2022

Known issue. Fix it or provide documentation about how to use fopSlideRef in footnotes.

@Rdeisenroth Rdeisenroth added the bug Something isn't working label Dec 20, 2022
@Rdeisenroth
Copy link
Member

The issue is a little bit bigger than just that, the way \fopSlideRef is currently implemented does not work in most PDF Viewers.

The issue lies here:

AlgoTeX/tex/algo-common.sty

Lines 880 to 888 in cd108c0

\href{\prop_item:Nn \g_rubos_document_opts_prop {fopslides} #4.pdf\#page=#1}{
\tl_if_novalue:nTF {#3} {
Kapitel~\seq_item:Nn \l_foo_seq {2}
\tl_if_novalue:nTF {#2} {
\tl_if_eq:nnTF{#1}{1}{~}{,~ab~Folie~#1~}
} {,~Folien~#1-#2~}
der~FOP
} {#3}
}

We should use \hyper@linkurl{text}{url} instead of \href{url}{text}.
Unfortunately this breaks our page reference, as the # may now no longer be escaped, which makes it conflict with the function parameters...
I will have to think of way to include a # without manually escaping it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants