Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minted v3 #67

Closed
ThexXTURBOXx opened this issue Oct 20, 2024 · 3 comments · Fixed by #70
Closed

minted v3 #67

ThexXTURBOXx opened this issue Oct 20, 2024 · 3 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@ThexXTURBOXx
Copy link
Contributor

Describe the bug
I have to say - I have not tested whether it works or not, but I guess that minted v3 might not work as sharelatex-full is structured currently.

Additional context
See the README of minted v3 for further reference on the installation process: https://github.com/gpoore/minted/tree/v3-dev?tab=readme-ov-file#development-status

Also these issues might provide even more insight: overleaf/toolkit#298 and gpoore/minted#401

@ThexXTURBOXx ThexXTURBOXx added the bug Something isn't working label Oct 20, 2024
@tuetenk0pp
Copy link
Owner

Hi, yeah this seems like a future problem. Will do some further reading an try not to produce this bug with the next release 😄

@ThexXTURBOXx
Copy link
Contributor Author

Thanks for the quick fix! :)
However, I seem to have difficulties getting a custom lexer to work.
I think this is because of the new regulations with the .latexminted_config file:
In order to enable loading of custom lexers from the Overleaf project (which could also be used for arbitrary code execution!!!), enable_cwd_config must be set to true in the config in either the user home directory or in TEXMFHOME.
I don't really know if it's the right way to allow it or to leave it disabled. As it currently stands, custom lexers are disallowed, but maybe they should be allowed?!
This is something that is completely for you @tuetenk0pp to decide, of course :)

@tuetenk0pp
Copy link
Owner

I don't like the idea of enabeling this by default but I see why some people would like the functionallity. Especially if there is a very limited amount of users in that instance. Maybe this could be achieved through a environment variable (OVERLEAF_MINTED_ENABLE_CWD_CONFIG) in config/variables.env in Overleaf Toolkit.

I would be happy to accept a PR on this as I don't have the time to do it myself right now.

@tuetenk0pp tuetenk0pp reopened this Nov 2, 2024
@tuetenk0pp tuetenk0pp added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants