Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sddi-social image variant #60

Open
BWibo opened this issue Apr 20, 2024 · 3 comments
Open

Remove sddi-social image variant #60

BWibo opened this issue Apr 20, 2024 · 3 comments
Assignees
Labels
type: discussion Questions, proposals and info that requires discussion.

Comments

@BWibo
Copy link
Member

BWibo commented Apr 20, 2024

This has never been completed and has never been used. Do we really need it @MarijaKnezevic?

@thomashkolbe
Copy link
Member

It might become useful again in the future. Does the inclusion of this image cause signficant extra work? If yes, we could also think about hibernating the image and to add an information at appropriate places that there is also the possibility to add public commenting of each dataset using Disqus (with a pointer to the repo), but that this facility is currently not maintained.
@BWibo, @MarijaKnezevic: What do you think?

@MarijaKnezevic
Copy link
Collaborator

@BWibo yes true. This function was never used. We can document the idea for this in the "Future Ideas Features" PR, but for now, to reduce maintenance, this can be deleted or mentioned that this image is only going to be updated if this funcionality will be required.

@BWibo BWibo changed the title Remove sddi-soial image variant Remove sddi-social image variant Apr 20, 2024
@BWibo
Copy link
Member Author

BWibo commented Apr 20, 2024

It's not really causing any extra work, but the extension we use does not seem to be maintained (last commit 2 years ago).
And we never tested if this is actually working. As this is a git repo, we are not losing anything if we remove it for now and leave a note that this feature is generally available.

I suggested this mainly because I would like to sharpen the idea of this repo a bit more clearly.
It should become more clear, that we provide a base image in this repo and we are open to integrate customized images in this repo, that build upon the base image. (see #58).

@BWibo BWibo added the type: discussion Questions, proposals and info that requires discussion. label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Questions, proposals and info that requires discussion.
Projects
None yet
Development

No branches or pull requests

3 participants