Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple issues with v3.0.1-beta #43

Closed
BWibo opened this issue Apr 21, 2024 · 0 comments
Closed

Multiple issues with v3.0.1-beta #43

BWibo opened this issue Apr 21, 2024 · 0 comments
Assignees
Labels

Comments

@BWibo
Copy link
Member

BWibo commented Apr 21, 2024

@MarijaKnezevic @ilchebedelovski

The beta release you did later the day is not operational and there are a couple of other issues with it.

  • The release was not published to the Helm repo of this repository (which is hosted via Github pages):

    $ helm repo update
    $ helm search repo -l --devel sddi-ckan/sddi-ckan
    
    NAME                    CHART VERSION   APP VERSION     DESCRIPTION
    sddi-ckan/sddi-ckan     3.0.0           2.0.0           Helm Chart for a SDDI enabled CKAN catalog. See...
    sddi-ckan/sddi-ckan     3.0.0-beta1     2.0.0           Helm Chart for a SDDI enabled CKAN catalog. See...
    sddi-ckan/sddi-ckan     2.0.0           2.0.0           Helm Chart for a SDDI enabled CKAN catalog. See...
    sddi-ckan/sddi-ckan     1.3.0-beta1     1.2.0           Helm Chart for a SDDI enabled CKAN catalog. See...
    ...
    ...

    To have the workflows of this repo publish releases, the version number in Chart.yaml needs to set to the new release number.

  • Branch naming:
    The branches you used are named bump/release-2.1.1, bump/release-3.0.1 - 2.1.2.
    This is misleading. Please name branches according to the version they contain, e.g. release/3.0.1-beta2.

  • The beta version you planned to release was not versioned. Please append a beta version at then end. This allows us to distinguish between beta versions. It is very likely, that we will have multiple betas until we all issues resolved for a release. E.g. 3.0.1-beta1, 3.0.1-beta2.

  • Selection of an improper version number. In this repo we want to conform to semantic versioning. This release is a pretty big change. I can't tell now if it includes breaking changes too. Please pick a version according to the semver definition.

  • The documentation of the Helm chart is not in sync with the changes that were made. Please read Contributing guide to set things up correctly.

  • Do not create releases from the Github UI. Releases of this repo are automatically managed by workflows, that are triggered by pushed to specific branches release/** or releases/** (see here and here).

  • There was no review process for the release. We could saved all of us a lot of time, if we went through a review process, before pushing this to the public. That would have brought up the issues mentioned above.

  • Should the new version of ckan-docker, v2.1.2 be used for this release? If yes, this is currently not the case.

So as you can see, this is quite a mess. Part of this is my own fault, because I did not document how it should have been done correctly. I addressed this in #41 and #42, but won't get to add this before June. I'll propose a proper workflow on how we do releases with a documentation when I'm back from parental leave in a month.

To get you beta release rolling, can we a quick meeting tomorrow? For now, I deleted the release and tag.

@BWibo BWibo self-assigned this Apr 21, 2024
@BWibo BWibo closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant