-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fine grained personal access tokens #458
Comments
@cbruno10 - thoughts on this? I know we looked at it a year or so ago and had some issues |
@graza-io, @cbruno10, Further more — I have a few findings related to the fine-grained access token. The error I tested the fix with the However, I’m not entirely sure if this is the best solution. Any thoughts would be appreciated. |
Hello everyone, I support Fine-grained personal access token (github_pat_) The permissions that the module requires in the documentation: https://hub.steampipe.io/plugins/turbot/github I suggest considering the points below if you are interested in attracting large companies to use your tool:
|
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
I've been using @ParthaI's add-support-for-fine-grained-access-token branch and it is working well for me. Are there plans to merge this? |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
@e-gineer I still believe that this is a great feature and it needs to be finished. |
Is your feature request related to a problem? Please describe.
Add support for fine grained personal access tokens to minimize the permissions needed to retrieve data from tables of interest to the user (up to the user to ensure they have added the right permissions to the FG PAT).
Describe the solution you'd like
This is a simple change in 4 places in
connect
andconnectV4
. Everywhere you validate that the supplied token has theghp_
prefix, also allow thegithub_pat_
prefix. I tested that this works as expected.The text was updated successfully, but these errors were encountered: