Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging API endpoint #32

Open
3 tasks
svenrademakers opened this issue Aug 15, 2023 · 0 comments
Open
3 tasks

Logging API endpoint #32

svenrademakers opened this issue Aug 15, 2023 · 0 comments

Comments

@svenrademakers
Copy link
Collaborator

svenrademakers commented Aug 15, 2023

Is your feature request related to a problem? Please describe.
Currently, inside the code, a Sender object is passed around to provide (eventually) log messages back to the client. I see an opportunity to improve this architecture, simultaneously adding value to the bmcd.

Describe the solution you'd like
A more elegant way is to create a logging Sink for the log crate that sends log messages to HTTP clients that are subscribed for logging information. This way, all the log statements inside our code debug!(), error!() warn!() are automatically sent, eliminating the need to use Sender objects.
This solution needs to be redfish compliant.

https://www.dmtf.org/sites/default/files/standards/documents/DSP0268_2023.1.pdf

Acceptance Criteria

  • There is a logging sink that hooks into Rust's logging framework
  • Bmcd implements the LogService and is exposed over the Restful API
  • Logging instances inside the code using Sender objects are replaced with conventional log statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant