Jaren Garman #588
Open
Jaren Garman #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix/initial fixes
Feature/registrant class
Feature/vehicle registration
Feature/license tests
Feature/vehicle factory
Feature/analytics
Feature/facility hours
Feature/ny vehicles
juliet-e
reviewed
Dec 18, 2024
|
|
||
| @facilities.map(&:registered_vehicles).flatten.group_by(&:county).max_by do |_county, vehicle_array| | ||
| vehicle_array.length | ||
| end[0] |
There was a problem hiding this comment.
Nice use of chained enumerables! As a complimentary exercise, it's a good idea to practice talking through these solutions as they are more complex, and describing your thought process and approach to a solution can be great interview practice!
juliet-e
reviewed
Dec 18, 2024
| end | ||
|
|
||
| def parse_address(facility) | ||
| "#{unless facility[:street_address_line_1].nil? |
There was a problem hiding this comment.
This block of code is not very readable. I would much rather a more multi-line process that extracts each component as a variable and then maybe joins them at the end or uses string interpolation to combine the data together. Anytime you're using \ to join long strings together, it generally could indicate unreadable string manipulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.