Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maia Bard #630

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Maia Bard #630

wants to merge 31 commits into from

Conversation

MaiaKBard
Copy link

No description provided.

@MaiaKBard
Add debuged code to facility file
13ed082
@MaiaKBard
Add attr_reader and debugged code for method facilities_offering_serv…
69694e4 
…ices
@MaiaKBard
Add instance @registration_date to eq nil
b1be1ef
@MaiaKBard
Merge pull request #1 from MaiaKBard/debugging
5a08f55 
Debugging
@MaiaKBard
Add initialize method to code and test file
9efb893
@MaiaKBard
Add method permit? and earn_permit to code and test files
a712f99
@MaiaKBard
Merge pull request #2 from MaiaKBard/registrant_class
95024b0 
Registrant class
@MaiaKBard
Moved uncommitted changes to vehicle_registration
1529543
@MaiaKBard
Add 'can add servies per facility' and 'has each facility hold their …
b7dbb1f 
…registered vehicles'
@MaiaKBard
Add .collected_fees method to code and test files
b3ca41d
@MaiaKBard
Add register_vehicle method to code and test file
fa0ead6
@MaiaKBard
Update register_vehicle method to include changing the date and add a…
0f4c439 
…n attr_accessor to code file
@MaiaKBard
Update test file to include 'can not perform services unless they are…
839ef1e 
… added to a facility' and code/test for register_vehicle(vehicle)
@MaiaKBard
Update test file with changes from @facility_1 to just @facility
1d4b46e
@MaiaKBard
Merge pull request #3 from MaiaKBard/vehicle_registration
abb120b 
Vehicle registration
@MaiaKBard
Add administer_written_test to code/test files
8133ec0
@MaiaKBard
Add adminster_written_test and administer_road_test to code/test file…
3506461 
…s and add a attr_accessor to registrant.rb file
@MaiaKBard
Take out binding.pry's
d249b6d
@MaiaKBard
Merge pull request #4 from MaiaKBard/getting_drivers_license
50f075b 
Getting drivers license
@MaiaKBard
Update spec_helper.rb
4325228
@MaiaKBard
Initialize FactoryVehichle class
272ca45
@MaiaKBard
Add create_vehicles(registration_data) method in code/test files
54191ec
@MaiaKBard
Create facility_factory code/test file
e262afd
@MaiaKBard
Add code/tests for class DMVFacility and class FacilityFactory
22ccc34
@MaiaKBard
Update before (:each) with CO, NY, MO - data, mappers, and facility i…
170d23d 
…nstances
@MaiaKBard
Create test for each DMV - 'creates DMVFacility objects from CO DMV d…
1d35615 
…ata' and 'assigns correct attributes'
@MaiaKBard
Create teats for missing data - 'returns an empty array when data is …
50cc863 
…not given' and 'runs with missing feilds'
@MaiaKBard
Update FacilityFactory class with a lambdas object argument and code
93ebb91
@MaiaKBard
Update code file with mapper objects and degugged code/tests
7105673
@MaiaKBard
Take code out of test file and channge my mapper objects into methods
0b72f7e
mikedao
mikedao reviewed Feb 19, 2025
View reviewed changes
Copy link

@mikedao mikedao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall well done. Code is clean. Like I said earlier, think about how you can separate out your code so that you're not relying on attr_accessors.

spec/registrant_spec.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, though for attributes I might have tested more than one example.

lib/registrant.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making license data accessbile, I'd have made a method to change the data. It's dangerous to have things as accessors. I would have a method like this:

def take_written_test
  @license_data[:written] = true
end

and call this method from the method in the facility class.

mikedao
mikedao reviewed Feb 20, 2025
View reviewed changes
lib/facility_factory.rb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lambdas - FANCY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedao mikedao mikedao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaiaKBard @mikedao