Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2 sql rubrics #228

Draft
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Draft

B2 sql rubrics #228

wants to merge 3 commits into from

Conversation

cjsim89
Copy link
Contributor

@cjsim89 cjsim89 commented Feb 24, 2023

Backend Curriculum PR Template

Description

Exploring changing the ActiveRecord category of project & assessment rubrics to be more general and accepting of both SQL and AR queries, emphasizing SQL as the base-level knowledge and full usage of AR as an "exceptional" score.

NOTE

  • This PR does not include rubrics for Adopt Don't Shop and Little Esty Shop, since those projects have rubrics contained in their README files (want to change this soon for consistency).

Why are we making this update?

Mod 2 curriculum currently includes more SQL concepts now, in order to teach what's going on "under the hood" of AR (particularly for Joins, Grouping and Aggregating, and more advanced concepts). In the past, AR was added onto the curriculum on top of the existing SQL requirements, and as such mod 2 may have become more difficult now because of the change. Additionally, students have been prevented from passing because they can implement SQL queries but the rubric says they must use AR, effectively punishing students for not being able to realize AR queries as effectively as SQL, while still being able to write a query.
Collectively, the team believes SQL skills are more important than AR skills, and these changes are meant to flow in the direction of prioritizing SQL learning over AR. As such, this PR contains changes to move "all-AR" requirements to the "exceptional" scores per rubric, while maintaining rules around "no Ruby used to process data" and "queries are implemented effectively".

Type of update

  • Minor update/fix -- no review requested
  • Moderate update -- review from Mod Team requested
  • Major update -- review from Backend Team requested

How will we measure the success of this change?

The effects of this might be greater than initially anticipated, but in the short-term, students will be able to differentiate their querying ability between both SQL and ActiveRecord, and use the one that makes the most sense to them in a given scenario. Effectively, students should/will not be punished for using SQL instead of AR.
In the longer term, students may come away from Mod 2 with a better understanding and confidence in using SQL, which may help them in their job search for positions that require more SQL usage than AR/other ORMs.

What questions do you have/what do you want feedback on? (optional)

  • Does the language in each rubric reflect what the Learning Goals for the mod are?
  • Do you believe the language in each rubric regarding Querying is clear?
  • (If applicable) Do you believe the change in the rubric will help or hurt students' progress on each project/assessment?

… SQL, changes from 'ActiveRecord helpers' to 'AR methods'
… SQL, changes from 'helpers' to 'methods'. Realigns Exceptional score to use no ruby.
Copy link
Contributor

@BrianZanti BrianZanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Chris, thanks for submitting this PR. I agree that students shouldn't be punished if they write their queries using more sql syntax than Active Record syntax. I think what I struggle with the most is the idea of "SQL Queries" and "ActiveRecord Queries". What we're really talking about is two different Active Record syntaxes. One style uses the .find_by_sql AR method, and the other uses the other AR methods that can be chained together, but both result in a SQL Query. So I think it's a really good idea to change the rubric category to "Querying", but I'm not sure it's helpful to make the distinction between SQL and AR Queries. Maybe instead we can refer to "ActiveRecord Queries" and in classes, checkins, etc. make sure they understand what counts as an "ActiveRecord Query". Specifically, that they are allowed to use the .find_by_sql method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants