create legacy class lesson; create prework; update index links #702
Conversation
✅ Deploy Preview for sage-cupcake-e1a0c3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
I think these are really great! The prework is hefty, but I think it's definitely something we should try to have the students do on their own. If it's notably impairing our ability to teach the refactoring lesson, then maybe we consider making it a taught lesson instead of async prework.
Overall, this is super great!
…along with a fun fact about method overriding, because why not
Thank you for the review! I updated the typos you found and made a change based on your notes. 🌞 |
There was a problem hiding this comment.
This looks great! I'm a little worried about the amount of content between the prework and the lesson but it all feels needed except for the deeper dive into inheritance (even though its not a deep dive really). My vote would be to cut that from both the prework and the lesson.
| ## Vocabulary | ||
| - `this` - a keyword with a value that changes depending on the context in which it's used | ||
| - `class` - a special function which acts as as a template for creating objects | ||
| - `inheritance` - a mechanism which derives a class from another class; one class can inherit properties and functionality from a parent class |
There was a problem hiding this comment.
I think I vote to cut inheritance. My preference would be to remove line 29.
There was a problem hiding this comment.
I think its find to use 'inherits' in references through because it just an english word that describes what is happening without going too deep.
There was a problem hiding this comment.
Sweet! I left the little sentence in the lesson that was like "the syntax uses the extends keyword to inherit properties and methods from a parent class" based on this sentiment. This way extends isn't a complete mystery but we don't dig into it. Hope that matches up.
I'm game for this! The lessons have been updated. I only included it since it's how React classes work and I figured not knowing about it would be too much magic - but they can just study up on that if they ever find themselves working in a legacy codebase. If they've been leaving the program without knowing this recently, then they definitely don't need to know it moving forward. I think this is the exact right thing to cut, so I'm glad you brought it up! A little magic never hurt anybody 😄 |
|
Going to merge without approval. I feel that having something merged and ready to go for next inning is better than nothing, since changes can be made whenever. |
Description of changes made
Motivation for any changes
Questions that you have for a reviewer
There's a lot of background information that's necessary to understand class components. Because of this, I set up the lesson as follows:
this, based on what I've seen in the calendars for M1 and M2. This is a crash course based on the original JS classes M1 lesson, but I made it so it is less hand-holdy for the M3 students. It's just a taster, unless they dig in on their own more.❓ What are your thoughts on this layout? Is it too much? What should be cut? Do we need the prework or should it be rolled into the full lesson or a separate JS classes lesson? Is the lesson too verbose? ❓
🗨️ PS - I used a lot of drop downs for the JS Class Crash Course, since it would be done individually as prework. I encourage looking at it in the browser instead of just reading the markdown so that it feels less stressful.