Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Router Lesson exercises #736

Open
hfaerber opened this issue Aug 29, 2023 · 1 comment
Open

Update Router Lesson exercises #736

hfaerber opened this issue Aug 29, 2023 · 1 comment
Labels
Lesson An issue affecting a lesson M3 M3 task

Comments

@hfaerber
Copy link
Contributor

Lesson to be updated: Router v6

Summary of changes needed:

  • There is a mistake in the organization of the Router lesson where the exercises aren't broken up correctly. Looks like they should all be broken out like Exercise # 1: Render Puppies and then Exercise # 2: Render Sharks and so on.
  • I wish it had the challenge for each step written out instead of just the code so that students could actually try to write it themselves before seeing the code. i.e. Step 5 could say: "Create a Route so that when the URL is /puppies, the Creatures component is rendered."
  • the nesting of Route in step 13 actually introduces a whole host of problems that require an Outlet and the use of index to fix. I suggest changing that block of code to NOT use nesting.
}/> } /> } /> If they want to learn about nesting, they can watch the video linked in the lesson. To be clear: the code block in the lesson does NOT work as-is. So it either needs to be updated to remove the nesting or add more code to make it work. I'd vote for the former. (edited)

Lesson creation guidelines (also on FE Hub)

@hfaerber hfaerber self-assigned this Aug 29, 2023
@hfaerber hfaerber added M3 M3 task Lesson An issue affecting a lesson labels Aug 29, 2023
@hfaerber
Copy link
Contributor Author

Update as of Week 1, 2310 inning - There were unmerged changes that had already been made. I'm dropping this ticket but leaving the notes so that @nicktu12 can decide if we need to make any additional changes to the lesson after teaching it with those previous changes merged in. HF

@hfaerber hfaerber removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lesson An issue affecting a lesson M3 M3 task
Projects
None yet
Development

No branches or pull requests

1 participant