Moodle 4.3 deprecation and mutated session

[ScottVerbeek]

Steps to reproduce on a vanilla Moodle 4.3.2 instance running on PHP 8.1.24 and given your plagiarism is setup:

• Open a course
• Add a new assignment
  • Give the assignment a name
  • Plagiarism turnitin plugin setting
    • Enable plugin -> No
• Save and display
• Observe deprecation and mutated sessions errors.

For convenience I have copied the messages:

Deprecation:

Deprecated: Return type of Integrations\PhpSdk\Soap::__doRequest($request, $location, $action, $version, $one_way = null) should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vanilla-403/plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php on line 369

Muted session:

Script /course/modedit.php mutated the session after it was closed: $SESSION->editedpages

    line 791 of /lib/classes/session/manager.php: call to debugging()
    line ? of unknownfile: call to core\session\manager::check_mutated_closed_session()
    line 159 of /lib/classes/shutdown_manager.php: call to call_user_func_array()
    line ? of unknownfile: call to core_shutdown_manager::shutdown_handler()

[simmonsgc]

In testing Turnitin Plagiarism plugin version 2024020501 on Moodle version 4.3.5+ (Build: 20240614) today, I received similar warning:

( ! ) Deprecated: Return type of Integrations\PhpSdk\Soap::__doRequest($request, $location, $action, $version, $one_way = null) should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/asulearn-test.appstate.edu/plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php on line 369

In my case, steps to reproduce:

• Open a course
• Enable editing
• Add activity or resource
• Click Assignment
• Observe deprecation and mutated sessions errors

Thanks,

[simmonsgc]

Good day, in testing today on the following:
Moodle Version 4.3.8+ (Build: 20241011)
Plagiarism Plugin: 2024072401
PHP vers 8.1.29

Still seeing Soap::_doRequest error:
( ! ) Deprecated: Return type of Integrations\PhpSdk\Soap::__doRequest($request, $location, $action, $version, $one_way = null) should either be compatible with SoapClient::__doRequest(string $request, string $location, string $action, int $version, bool $oneWay = false): ?string, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/asulearn-test.appstate.edu/plagiarism/turnitin/vendor/Integrations/phpsdk-package/src/Soap.php on line 369

To recreate in the above environment:

1. Open a course
2. Enable editing
3. Add an activity or resource
4. Choose Assignment
5. Observe deprecation and warnings

Full stack trace attached.
new_assignment_trace.txt

Was following #702 - is this still an issue?

Many thanks,