Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for not active theme not recognized #12

Open
Henk57 opened this issue May 31, 2019 · 2 comments
Open

Update for not active theme not recognized #12

Henk57 opened this issue May 31, 2019 · 2 comments

Comments

@Henk57
Copy link

Henk57 commented May 31, 2019

I use the plugin for more then 2 years now with compliments.

I had made a new child theme update. I can put in in the repos, but this update is not shown to a site that has the child installed, but now uses an other active theme.
Normally updates of non-active themes are shown.
After selecting the child once, the update is found. Switching back to the earlier theme, and the update notification stays.
Perhaps you can have a look at this issue, or tell me what I might have missed in the instructions.

@turtlepod
Copy link
Owner

Hi @Henk57
Inactive theme/plugin code are not loaded/run.

So, the updater is on inactive theme/plugin, no update will happen/displayed.

Inactive theme/plugin hosted at wordpress.org will still show, because it's how WP works (that's the default system in wordpress)

this updater is a custom updater, if the plugin/theme is not active. your wp installation will not aware it even exists.

Solution:

Add your theme/child theme updater in a plugin using the "group updater" feature.
https://genbumedia.com/docs/fx-updater-groups/

@Henk57
Copy link
Author

Henk57 commented May 31, 2019

Ok.
I've changed the 'type' to 'group' (was 'theme')
and put the slug of the group I made on the server to 'cs-zakra-child'. I made the child theme member of this group.
But the update doesn't show up in the Wordpress updater (version 1.0.2 should go to 1.0.3).
It does show up correctly when the child theme is selected first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants