Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable handling of duplicate hermes ids #282

Open
PrenSJ2 opened this issue Sep 10, 2024 · 1 comment · May be fixed by #289
Open

Re-enable handling of duplicate hermes ids #282

PrenSJ2 opened this issue Sep 10, 2024 · 1 comment · May be fixed by #289

Comments

@PrenSJ2
Copy link
Member

PrenSJ2 commented Sep 10, 2024

I think because this function is broken, It is called to update on every webhook

Proposed Solution

  1. call handle_duplicate_hermes_ids only if the hermes_id is a string
  2. only update the objects if there has been a change
This was referenced Sep 10, 2024
Closed
Closed
@PrenSJ2
Copy link
Member Author

PrenSJ2 commented Sep 11, 2024 

pydantic_core._pydantic_core.ValidationError
1 validation error for PipedriveEvent
previous.8c2f326b6be255cd3d5cf4ee7385eaf544a47f1d
  Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='89718, 89951', input_type=str]
    For further information visit https://errors.pydantic.dev/2.8/v/int_parsing

when rewriting the handling of the duplicate hermes ids

  • should not validate / ignore the value in the previous section of the webhook, perhaps by setting it to none, (if the value is a sting with a comma)

This was referenced Sep 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle duplicate hermes ids without an infinate loop tutorcruncher/hermes
1 participant
@PrenSJ2