Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$input-bg must be a string in latest Bootstrap version #37620

Closed
3 tasks done
Tracked by #37549
robinheidrich opened this issue Dec 9, 2022 · 1 comment · Fixed by #37621
Closed
3 tasks done
Tracked by #37549

$input-bg must be a string in latest Bootstrap version #37620

robinheidrich opened this issue Dec 9, 2022 · 1 comment · Fixed by #37621

Comments

@robinheidrich
Copy link

Prerequisites

Describe the issue

I installed the Bootstrap GitHub repository via npm to try darkmode.

If I change the $input-bg in my _variables.scss to #fff I get the following error message:

[plugin:vite:css] [sass] $string: #fff is not a string.
    ╷
132 │   @if str-index($string, "data:image/svg+xml") {
    │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
  node_modules\bootstrap\scss\_functions.scss 132:7            escape-svg()
  node_modules\bootstrap\scss\forms\_form-check.scss 30:32     @import
  node_modules\bootstrap\scss\_forms.scss 5:9                  @import

This is not the case in the current Bootstrap version, so I assume it is a bug.

Reduced test cases

The problem occurs in SCSS therefore I could not create a working test case on CodePen.

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

5.2.3 (main branch)

@julien-deramond
Copy link
Member

julien-deramond commented Dec 10, 2022

Thanks for the feedback @robinheidrich. I'm adding it as a reference into our #37549 to take a look at it :)

@julien-deramond julien-deramond moved this to To do in v5.3.0 Dec 10, 2022
Repository owner moved this from To do to Done in v5.3.0 Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants