Skip to content
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.

If # of commits in PR ≥ 20, assume accidental PR against wrong repo #15

Open
cvrebert opened this issue Aug 7, 2014 · 4 comments
Open

If # of commits in PR ≥ 20, assume accidental PR against wrong repo #15

cvrebert opened this issue Aug 7, 2014 · 4 comments
Assignees
@cvrebert
Labels
enhancement help wanted

Comments

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 7, 2014

(Or botched rebase, or etc...)
Refs twbs/bootstrap#14351
@hnrch02 hnrch02 mentioned this issue Nov 4, 2014
Closed
@hnrch02
Copy link
Collaborator

hnrch02 commented Nov 4, 2014

Could be problematic because of for example twbs/bootstrap#14951.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Nov 4, 2014

That PR is a statistical outlier, but yeah, the limit can be debated and twerked.
And/or maybe only enforce it on the initial opening of the PR.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Nov 4, 2014

Maybe also put in a heuristic about the commits having N different authors and the requester not authoring a majority of the commits.

@hnrch02
Copy link
Collaborator

hnrch02 commented Nov 4, 2014

That sounds good. Looking forward to the limit being twerked! 😄

@cvrebert cvrebert self-assigned this Oct 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cvrebert cvrebert

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvrebert @hnrch02