Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylelint-stylistic #206

Open
tkrotoff opened this issue Jun 3, 2023 · 1 comment
Open

Remove stylelint-stylistic #206

tkrotoff opened this issue Jun 3, 2023 · 1 comment

Comments

@tkrotoff
Copy link

tkrotoff commented Jun 3, 2023

With stylelint 15 the stylistic rules have been removed in favor of tools like Prettier.

When we created these rules, pretty printers (like Prettier) didn't exist. They now offer a better way to consistently format code, especially whitespace. Linters and pretty printers are complementary tools that work together to help you write consistent and error-free code.

So should stylelint-config-twbs-bootstrap: let the user configure Prettier instead of using stylelint-stylistic which is a temporary solution because not all projects are able to shift easily.

Before stylelint 15 & stylelint-config-twbs-bootstrap 8.0.0, stylelint-config-prettier (deprecated & archived) allowed to disable all stylistic rules in conflict with Prettier.

stylelint-config-twbs-bootstrap >= 8.0.0 requires the users to manually disable each rules from stylelint-stylistic to avoid conflicts with Prettier.

@XhmikosR
Copy link
Member

XhmikosR commented Jun 3, 2023

Unsure what's the proposed solution here.

I don't like the upstream choice to deprecate the stylistic rules, and the approach I followed is to keep the old behavior as close as possible with the use of stylelint-stylistic.

You could ask there for an off switch, but it's not something I want to implement here.

tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 15, 2023
Replace `stylelint-stylistic` with `stylelint-codeguide` to allow
upgrade to Stylelint 16

Also changes Node version constraints to match `stylelint-codeguide`
requirements

Ref:
- elirasza/stylelint-stylistic#17
- https://github.com/firefoxic/stylelint-codeguide


Close twbs#232, close twbs#206
tagliala added a commit to tagliala/stylelint-config-twbs-bootstrap that referenced this issue Dec 19, 2023
Replace `stylelint-stylistic` with `@stylistic/stylelint-plugin` to allow
upgrade to Stylelint 16

Also changes Node version constraints to match new minimum requirements

Ref:
- elirasza/stylelint-stylistic#17
- https://github.com/stylelint-stylistic/stylelint-stylistic

Close twbs#232, close twbs#206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants