From c99e01107019bf55844a085d99cc93b18ec8fcbf Mon Sep 17 00:00:00 2001
From: Timo <dev@2515.ch>
Date: Wed, 31 Jan 2024 09:17:27 +0100
Subject: [PATCH] Map `store_item`: Take item by reference instead of by value

---
 README.md                |  1 +
 fuzz/fuzz_targets/map.rs |  2 +-
 src/map.rs               | 24 ++++++++++++------------
 3 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/README.md b/README.md
index 34bbc60..e3e9de8 100644
--- a/README.md
+++ b/README.md
@@ -91,6 +91,7 @@ When using peek_many, you can look at all data from oldest to newest.
 (DD-MM-YY)
 
 ### Unreleased
+- *Breaking* The item to store is now passed by reference to Map `store_item`
 
 ### 0.7.0 10-01-24
 
diff --git a/fuzz/fuzz_targets/map.rs b/fuzz/fuzz_targets/map.rs
index b2fc862..646d4e4 100644
--- a/fuzz/fuzz_targets/map.rs
+++ b/fuzz/fuzz_targets/map.rs
@@ -124,7 +124,7 @@ fn fuzz(ops: Input) {
                         &mut flash,
                         FLASH_RANGE,
                         &mut buf.0,
-                        item.clone(),
+                        &item,
                     )) {
                         Ok(_) => {
                             map.insert(item.key, item.value);
diff --git a/src/map.rs b/src/map.rs
index 2acb1a6..1846c36 100644
--- a/src/map.rs
+++ b/src/map.rs
@@ -91,7 +91,7 @@
 //!     &mut flash,
 //!     flash_range.clone(),
 //!     &mut data_buffer,
-//!     MyCustomType { key: 42, data: 104729 },
+//!     &MyCustomType { key: 42, data: 104729 },
 //! ).await.unwrap();
 //!
 //! // When we ask for key 42, we not get back a Some with the correct value
@@ -241,7 +241,7 @@ pub async fn store_item<I: StorageItem, S: NorFlash>(
     flash: &mut S,
     flash_range: Range<u32>,
     data_buffer: &mut [u8],
-    item: I,
+    item: &I,
 ) -> Result<(), MapError<I::Error, S::Error>> {
     assert_eq!(flash_range.start % S::ERASE_SIZE as u32, 0);
     assert_eq!(flash_range.end % S::ERASE_SIZE as u32, 0);
@@ -733,7 +733,7 @@ mod tests {
             &mut flash,
             flash_range.clone(),
             &mut data_buffer,
-            MockStorageItem {
+            &MockStorageItem {
                 key: 0,
                 value: vec![5],
             },
@@ -744,7 +744,7 @@ mod tests {
             &mut flash,
             flash_range.clone(),
             &mut data_buffer,
-            MockStorageItem {
+            &MockStorageItem {
                 key: 0,
                 value: vec![5, 6],
             },
@@ -764,7 +764,7 @@ mod tests {
             &mut flash,
             flash_range.clone(),
             &mut data_buffer,
-            MockStorageItem {
+            &MockStorageItem {
                 key: 1,
                 value: vec![2, 2, 2, 2, 2, 2],
             },
@@ -793,7 +793,7 @@ mod tests {
                 &mut flash,
                 flash_range.clone(),
                 &mut data_buffer,
-                MockStorageItem {
+                &MockStorageItem {
                     key: (index % 10) as u8,
                     value: vec![(index % 10) as u8 * 2; index % 10],
                 },
@@ -821,7 +821,7 @@ mod tests {
                 &mut flash,
                 flash_range.clone(),
                 &mut data_buffer,
-                MockStorageItem {
+                &MockStorageItem {
                     key: 11,
                     value: vec![0; 10],
                 },
@@ -864,7 +864,7 @@ mod tests {
             };
             println!("Storing {item:?}");
 
-            store_item::<_, _>(&mut tiny_flash, 0x00..0x40, &mut data_buffer, item)
+            store_item::<_, _>(&mut tiny_flash, 0x00..0x40, &mut data_buffer, &item)
                 .await
                 .unwrap();
         }
@@ -874,7 +874,7 @@ mod tests {
                 &mut tiny_flash,
                 0x00..0x40,
                 &mut data_buffer,
-                MockStorageItem {
+                &MockStorageItem {
                     key: UPPER_BOUND,
                     value: vec![0; UPPER_BOUND as usize],
                 },
@@ -914,7 +914,7 @@ mod tests {
             };
             println!("Storing {item:?}");
 
-            store_item::<_, _>(&mut big_flash, 0x0000..0x1000, &mut data_buffer, item)
+            store_item::<_, _>(&mut big_flash, 0x0000..0x1000, &mut data_buffer, &item)
                 .await
                 .unwrap();
         }
@@ -924,7 +924,7 @@ mod tests {
                 &mut big_flash,
                 0x0000..0x1000,
                 &mut data_buffer,
-                MockStorageItem {
+                &MockStorageItem {
                     key: UPPER_BOUND,
                     value: vec![0; UPPER_BOUND as usize],
                 },
@@ -966,7 +966,7 @@ mod tests {
                     value: vec![i as u8; LENGHT_PER_KEY[i]],
                 };
 
-                store_item::<_, _>(&mut flash, 0x0000..0x4000, &mut data_buffer, item)
+                store_item::<_, _>(&mut flash, 0x0000..0x4000, &mut data_buffer, &item)
                     .await
                     .unwrap();
             }