Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for yoyo and repeat with nested objects (make changes if needed). #542

Closed
trusktr opened this issue May 31, 2020 · 1 comment
Closed

Comments

@trusktr
Copy link
Member

trusktr commented May 31, 2020

With the merge of #539 and #541 we got support for animating properties inside nested object or arrays.

But we haven't tested repeat or yoyo with this yet. We should add some tests and and example, and update the implementation if needed.

@trusktr
Copy link
Member Author

trusktr commented Jan 15, 2024

Instead of ensuring we support more complexity, we will move towards decoupled features with separation of concerns, for example making a Timeline for managing multiple tweens instead of overloading a single class with many features in an unmanageable way.

So, we'll close this in favor of moving in that direction, and features like yoyo and repeat will be separate concepts on their own, hence this problem goes away, and things will be simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant