Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After creating new record or clicking 'c', global redirect shortcuts don't work #6631

Open
BOHEUS opened this issue Aug 15, 2024 · 10 comments
Open

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Aug 15, 2024

Scenario 1:

  1. Log in
  2. Create new record
  3. Try to go to other page using shortcuts listed in Search sub-tab

Scenario 2:

  1. Log in
  2. Click c on keyboard (new row at the top of the table appears like user would like to create new object)
  3. Try to go to other page using shortcuts listed in Search sub-tab
    Actual: No action, seems like cursor is still focused on table or row in table

Expected: User should be redirected to tab accordingly to pressed key combinations listed in Search

@Nabhag8848
Copy link
Contributor

Nabhag8848 commented Aug 25, 2024

@BOHEUS can't reproduce. Looks like already fixed, can be closed

Screen.Recording.2024-08-25.at.4.55.48.PM.mov

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Aug 25, 2024

No, it's not fixed, I can still reproduce it, also, I didn't mention anything about going to Settings and creating a entirely new object. Not only that, you tried to reproduce only first scenario where I wrote 2 scenarios (maybe there are more ways to reproduce the bug but I didn't find more).

Here's proof the bug is still reproducible (even on demo)

@Nabhag8848
Copy link
Contributor

Thanks, you meant Create new object-record. Create new object was confusing to me.

@Bonapara
Copy link
Member

@lucasbordeau linked to shortcuts

@lucasbordeau
Copy link
Contributor

lucasbordeau commented Aug 29, 2024

BOHEUS could you please update the issue by replacing object with record, it's very confusing otherwise as we make a clear distinction between an object (which relates to metadata) and a record, which relate to an instance in table or board.

We can create an object in settings
We can create a record in table and board

@BOHEUS BOHEUS changed the title After creating new object or clicking 'c', global redirect shortcuts don't work After creating new record or clicking 'c', global redirect shortcuts don't work Aug 29, 2024
@BOHEUS
Copy link
Contributor Author

BOHEUS commented Aug 29, 2024

@lucasbordeau done

@lucasbordeau
Copy link
Contributor

lucasbordeau commented Sep 4, 2024

Thanks for the update.

I tried to reproduce by following your videos, sadly I couldn't reproduce.

Could you try finding the precise sequence of actions that creates this shortcut freeze ?

It could help to set DEBUG_HOTKEY_SCOPE to true in useScopedHotkeyCallback so you have logs that indicate what is the current hotkey scope when you press some keys.

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Sep 4, 2024

@lucasbordeau that's what I get when DEBUG_HOTKEY_SCOPE is set to true
image
For comparison, that's what I get when I can use shortcuts to jump between different tabs (messages in green)
image

@lucasbordeau
Copy link
Contributor

Are you sure that you have no soft focus left on any cell when trying to input those keys ?

Otherwise this would mean that even if we exit soft focus mode, the hotkey scope is still on soft focus mode, which would need to be fixed.

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Sep 5, 2024

I don't think I have soft focus on any cell after creating the record but how can I check it to make sure my statement is true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants