Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group by disabled colors #9874

Closed
Bonapara opened this issue Jan 27, 2025 · 3 comments · Fixed by #9923
Closed

Fix group by disabled colors #9874

Bonapara opened this issue Jan 27, 2025 · 3 comments · Fixed by #9923
Assignees
@magrinj
Labels
prio: high

Comments

@Bonapara
Copy link
Member

Bonapara commented Jan 27, 2025 •
edited
Loading

Current behavior

The group by menu item has a 0,4 opacity on main views, making visibility poor.

Image

Desired Behavior

The icon and title should be "tertiary" - no opacity should be applied. No chevron right should be displayed

Image

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=52889-250170&t=Nz7vd3GzKET2PL57-11
@charlesBochet charlesBochet moved this to 🔖 Planned in 🎯 Roadmap & Sprints Jan 28, 2025
@falgunmpatel
Copy link
Contributor

@Bonapara I would like to contribute to this issue? Should I proceed?

@magrinj magrinj moved this from 🔖 Planned to 🏗 In Progress in 🎯 Roadmap & Sprints Jan 30, 2025
@magrinj magrinj mentioned this issue Jan 30, 2025
Merged
@Bonapara
Copy link
Member Author

I think @magrinj will fix it during the spring @falgunmpatel, maybe you can grab another Good First Issue?

@magrinj magrinj moved this from 🏗 In Progress to 👀 In review in 🎯 Roadmap & Sprints Jan 30, 2025
charlesBochet pushed a commit that referenced this issue Jan 30, 2025
@magrinj
feat: MenuItem disabled color (#9923)
e7da9b6 
Fix #9874
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🎯 Roadmap & Sprints Jan 30, 2025
@falgunmpatel
Copy link
Contributor

Sounds good! I'll take a look at other Good First Issues. Thanks for the heads-up! 👍 @Bonapara.

eliezer-rodrigues037 pushed a commit to mind-developer/kvoip-v2 that referenced this issue Jan 30, 2025
@magrinj @eliezer-rodrigues037
feat: MenuItem disabled color (twentyhq#9923)
bf794a2 
Fix twentyhq#9874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magrinj magrinj

Labels
prio: high
Projects
🎯 Roadmap & Sprints
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: MenuItem disabled color twentyhq/twenty
3 participants
@magrinj @Bonapara @falgunmpatel