-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHPStan for Twig 4.x #4466
Fix PHPStan for Twig 4.x #4466
Conversation
@VincentLanglet I've just merged 3.x into 4.x to keep this PR only about phpstan. |
cb89b75
to
e8fe4a1
Compare
402e96f
to
97ef15c
Compare
For the iterable/Iterator issue, I think it's an issue with PHPStan instead. |
Let's revert the change then. |
I reverted the extra if I added. We still need |
97ef15c
to
981babc
Compare
981babc
to
0cb1728
Compare
I rebased @fabpot |
Thank you @VincentLanglet. |
Hi @fabpot, to help introducing PHPStan on 4.x, I made the merge 3.x into 4.x
I have
A commit with the merge 6a82e16
A commit with the update needed to get PHPStan build green in 4.x cb89b75