Skip to content

Custom icon and modal request for keyboard shortcuts #2873

Discussion options

You must be logged in to vote

Hi @Fazle-Jahangir!

Thanks for your questions. For the second one about Modal: our Modal has a min-height but will grow up to a max-height of 90% and then automatically become scrollable after that has been reached, so you shouldn't have to worry about the length of the list or changing the height!

The team is still discussing adding the icon, but a few observations:

  • Our general advice is to avoid having solely an icon as a button, unless the single action it performs is clearly conveyed. One way to make this much clear is to write it out and have it be a link-style button. Here's a quickly drawn up example:

  • You mentioned that this "is not something users would check often but useful …

Replies: 1 comment 2 replies

Comment options

You must be logged in to vote
2 replies
@Fazle-Jahangir
Comment options

@gloriliale
Comment options

Answer selected by Fazle-Jahangir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants