treatment of deletion confirmation on top of side modal #3209
-
Beta Was this translation helpful? Give feedback.
Answered by
serifluous
Apr 28, 2023
Replies: 1 comment 3 replies
-
Hey @simsemma ! Can you explain more about "i feel like it's typically not great to do a dialog on top of a side modal here"? Is it the asymmetry or the overlay-on-overlay (or something else) part of the treatment that makes you feel like it's not great? |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Yeeeah, it's one of the downsides of over-relying on overlays and dialogs 😬, but there's nothing necessarily wrong with it. Alert Dialogs are meant to focus attention and block everything else, so they're serving their purpose here.
If the action is low-severity enough / pretty easily reversible and you're trying to avoid the overlay-on-overlay, you could consider not showing the Alert Dialog on-delete, and pop a toast when the deletion has gone through, ideally with an undo button.