Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ngrok configuration to be passed in #158

Open
dsmwong opened this issue Jul 30, 2020 · 4 comments · May be fixed by #177
Open

Allow ngrok configuration to be passed in #158

dsmwong opened this issue Jul 30, 2020 · 4 comments · May be fixed by #177
Milestone
Improvements/Nice...

Comments

@dsmwong
Copy link

dsmwong commented Jul 30, 2020 •
edited
Loading

Hi,

It would be good to be able to add additional options to allow ngrok configuration to be passed in. The following use cases for --ngrok action

  1. pass in subdomain into ngrok so it generate a consistent URI for ngrok
  2. pass in user specified configuration file instead of using ~/.ngrok2/ngrok.yml for configration. This will allow project specific ngrok configuration to be set.
@welcome
Copy link

welcome bot commented Jul 30, 2020

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog

@dsmwong
Copy link
Author

dsmwong commented Jul 30, 2020

Apologies - wrong project. moving to serverless plugin.

@dsmwong dsmwong closed this as completed Jul 30, 2020
@philnash
Copy link
Contributor

Actually I think this is where most of the implementation would go. @twilio-labs/plugin-serverless#38 will be needed so that the Serverless Plugin gets the options added.

@philnash philnash reopened this Jul 31, 2020
@dkundel dkundel added this to the v3 milestone Aug 10, 2020
@philnash philnash linked a pull request Aug 24, 2020 that will close this issue
Open
1 task
@philnash
Copy link
Contributor

Hey @dsmwong, just took a look at this. Two bits of good news:

  1. You can already pass in a subdomain to the ngrok command, there's no separate option, you just pass it with --ngrok like so: 
    $ twilio serverless:start --ngrok=subdomain
or
$ npx twilio-run --ngrok=subdomain
  2. I've just opened a PR to implement custom config and named tunnels. I'd appreciate feedback on that, if you have time.

@philnash philnash modified the milestones: v3, Post v3 Feb 25, 2021
This was referenced Sep 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Improvements/Nice to haves
Development

Successfully merging a pull request may close this issue.

feat(twilio-run:start): options for ngrok config and named tunnel twilio-labs/serverless-toolkit
4 participants
@philnash @dsmwong @dkundel @makserik