Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redaction manipulates actual secrets in debug mode #334

Open
dkundel opened this issue Aug 17, 2021 · 0 comments
Open

Redaction manipulates actual secrets in debug mode #334

dkundel opened this issue Aug 17, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@dkundel
Copy link
Member

dkundel commented Aug 17, 2021

Actual Behavior

If you deploy a project with -l debug that contains any of these keywords here as names of environment variables

'authToken',
'apiSecret',
'username',
'password',
'cookies',
'AUTH_TOKEN',
'API_SECRET',
'TWILIO_AUTH_TOKEN',
'TWILIO_API_SECRET',

The environments variables will be uploaded as [REDACTED] instead.

Expected Behavior

The environment variables get uploaded the exact way they are referenced but the logs show them as [REDACTED].

How to Reproduce

twilio serverless:init sample
cd sample
echo "API_SECRET=something" >> .env
twilio serverless:deploy -l debug
twilio serverless:env:get --key API_SECRET
# shows [REDACTED]
twilio serverless:deploy
twilio serverless:env:get --key API_SECRET
# shows actual value something
# both should be "something"

Versions

Node.js: 12.22.1
@twilio/runtime-handler: 1.1.3
@twilio-labs/plugin-serverless: 2.2.2

@makserik makserik added this to the Post v3 milestone Mar 25, 2024
@makserik makserik added the bug Something isn't working label Mar 25, 2024
@makserik makserik added the good first issue Good for newcomers label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants