Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin modification for redmine 3.4.2 on ruby 2.4 #40

Open
wlk-cz opened this issue Sep 3, 2017 · 4 comments
Open

Plugin modification for redmine 3.4.2 on ruby 2.4 #40

wlk-cz opened this issue Sep 3, 2017 · 4 comments

Comments

@wlk-cz
Copy link

wlk-cz commented Sep 3, 2017

I am not ruby specialist, but I spend last two days learning this language to get this plugin work. I have to change array association on many places from @settings[:client_id] to @settings['client_id'] for all plugin parameters. Can someone explain me, why? Without this modification the plugin didn't store settings and didn't show google login button.

@etonline
Copy link

etonline commented Sep 6, 2017

Thank you for digging this, it works for my newly install Redmine :)

However, the Google Login button doesn't show...

@babykart
Copy link

babykart commented Dec 5, 2017

@wlk-cz thank you for your patch that fixed on:

Environment:
  Redmine version                3.4.3.stable
  Ruby version                   2.2.8-p477 (2017-09-14) [x86_64-linux]
  Rails version                  4.2.8
  Environment                    production
  Database adapter               Mysql2
SCM:
  Git                            2.15.1
  Filesystem                     
Redmine plugins:
  redmine_omniauth_google        0.0.1

@guss77
Copy link

guss77 commented Dec 17, 2017

Also works for me 👍 .

@twinslash, please merge? 🙏

@ahosch
Copy link

ahosch commented Jan 14, 2018

This worked for me as well using the pull request associated with #42 Replace not working with symbols to strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants