Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmantissa.web.SiteConfiguration doesn't work with StringEndpointPort #54

Open
mithrandi opened this issue Feb 26, 2016 · 3 comments
Open

xmantissa.web.SiteConfiguration doesn't work with StringEndpointPort #54

mithrandi opened this issue Feb 26, 2016 · 3 comments
Labels
bug

Comments

@mithrandi
Copy link
Contributor

SiteConfiguration specifically looks for TCPPort to find an unsecured port, and SSLPort to find a secured port. If you only have StringEndpointPorts in your site, it'll never be able to generate absolute URIs.
@mithrandi mithrandi added the bug label Feb 26, 2016
@glyph
Copy link
Member

glyph commented Apr 27, 2016

This is kind of unsolvable in the general case; StringEndpoint may well result in something that there's no way to generate a proper HTTP URL for.

@glyph
Copy link
Member

glyph commented Apr 27, 2016

Instead of inferring from a TCPPort object, perhaps we should have an explicit NetLoc object?

@mithrandi
Copy link
Contributor Author

See #67.

@mithrandi mithrandi mentioned this issue Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glyph @mithrandi